Adium

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#9950 closed defect (fixed)

Adium should use the time attribute of the chat element to determine the datestamp of a chatlog file

Reported by: boredzo Owned by: boredzo
Milestone: Adium 1.3 Component: Adium UI
Version: Severity: normal
Keywords: Cc:
Patch Status:

Description

Even in r23786, the Date column will still show an empty cell if a chatlog has a filename like “jrandomhacker ((null)).chatlog”, proving that it's still getting the date from the filename.

Change History (4)

comment:1 Changed 12 years ago by Peter Hosey

Owner: changed from nobody to Peter Hosey
Status: newassigned

comment:2 Changed 12 years ago by Peter Hosey

Resolution: fixed
Status: assignedclosed

(In [23790]) Instead of parsing the datestamp from a chatlog's filename, read the file and get it from the first element that has one. This is a tiny bit slower, but more likely to work and be accurate, especially if somebody decides to rename a chatlog file or the file has ?\226?\128?\156(null)?\226?\128?\157 as the date in its filename. Fixes #9950.

We still use dateFromFileName as a fallback, especially for .AdiumHTMLLog files.

comment:3 Changed 12 years ago by Robert

Milestone: Adium X 1.3

comment:4 Changed 12 years ago by Peter Hosey

(In [23814]) Try getting the date from the filename first, and only try to parse XML if that fails. I dislike this, but it's necessary for users with large logs, because NSXMLParser (despite being stream-based) slurps the whole log before parsing, which makes the Transcript Viewer painfully slow since r23790.

Refs #9950.

Note: See TracTickets for help on using tickets.