Adium

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#9795 closed defect (fixed)

Linkification of enclosed URIs with trailing punctuation is incorrect

Reported by: earthmkii Owned by: earthmkii
Milestone: Adium 1.3 Component: Message View
Version: Severity: normal
Keywords: url uri hyperlink linkification Cc:
Patch Status:

Description

URIs with tailing punctuation are truncated when enclosed.

ex:

<http://en.wikipedia.org/wiki/Safari_(web_browser)>

The result should be: <http://en.wikipedia.org/wiki/Safari_(web_browser)>, however only <http://en.wikipedia.org/wiki/Safari_(web_browser)> is linkified.

Change History (5)

comment:1 Changed 12 years ago by Stephen Holt

Status: newassigned

comment:2 Changed 12 years ago by Jordan

Milestone: Adium X 1.3.x

Setting to the same milestone as it's sister ticket ... though if you have a patch ready before 1.3 is released then it'll likely get included in that :)

comment:3 Changed 12 years ago by Stephen Holt

Just a note: this also affects URI's based on IPv6 addresses. Since they're required to be enclosed in brackets, -[SHHyperlinkScanner nextURLFromString:] removes the closing bracket from the matching set, forcing the URI to be invalid.

comment:4 Changed 12 years ago by sholt

Resolution: fixed
Status: assignedclosed

(In [23358]) Make sure enclosed parts of URLs are linked if they are on an edge and are non-nested (ex: <http://example.com/foo_(bar)>). Fixes #9795.

comment:5 Changed 12 years ago by David Smith

Milestone: Adium X 1.3.xAdium X 1.3
Note: See TracTickets for help on using tickets.