Adium

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#9511 closed defect (fixed)

Crash when selecting "Undo Typing" or "Redo Typing" after closing a conversation tab

Reported by: 4ndy Owned by: evands
Milestone: Adium 1.2.4 Component: Adium UI
Version: Severity: normal
Keywords: crash undo redo tab Cc:
Patch Status:

Description

After typing text into a conversation tab, if the tab is then closed, the "Undo Typing" option (or "Redo Typing" if "Undo Typing" action has been performed) is still available. If selected, or if the hotkey (command-z) is used, Adium will crash.

Note: The"Undo" option is not available if the last tab (and therefore the window) has been closed.

Using Adium 1.2.3, OS X 10.4.11, AOL Instant Messenger account.

Attachments (1)

Adium.crash.log (93.1 KB) - added by 4ndy 12 years ago.

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by 4ndy

Attachment: Adium.crash.log added

comment:1 Changed 12 years ago by Robert

Milestone: Adium X 1.2.4

I can reproduce this in 1.2.3.

comment:2 Changed 12 years ago by Robert

and in 1.3svn, also.

comment:3 Changed 12 years ago by Jordan

Milestone: Adium X 1.2.4Adium X 1.2.5

We've got enough for 1.2.4 already, and this is not a regression - it's been around for a while, so no need to hold up an imminent release for it.

comment:4 Changed 12 years ago by Evan Schoenberg

Milestone: Adium X 1.2.5Adium X 1.2.4
Owner: changed from nobody to Evan Schoenberg
Status: newassigned

Yup, but it offended my tired sensibilities ;)

comment:5 Changed 12 years ago by Evan Schoenberg

Resolution: fixed
Status: assignedclosed

(In [22966]) Each message view controller now provides a unique undo manager to its message entry text view. If we don't do this, we end up with a single undo manager for the whole window per the documentation on the undo manager hierarchy.

This fixes a number of obscure undo/redo bugs in the message window, including crashes after closing a tab and invoking undo/redo (fixes #9511) and undo/redo working across multiple tabs (only one of which is visible) which was just weird.

comment:6 Changed 12 years ago by Evan Schoenberg

(In [22967]) Merged [22966]: Each message view controller now provides a unique undo manager to its message entry text view. If we don't do this, we end up with a single undo manager for the whole window per the documentation on the undo manager hierarchy.

This fixes a number of obscure undo/redo bugs in the message window, including crashes after closing a tab and invoking undo/redo (fixes #9511) and undo/redo working across multiple tabs (only one of which is visible) which was just weird.

Note: See TracTickets for help on using tickets.