Adium

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#9335 closed defect (fixed)

Bookmark chat allows bookmarking of single user conversations

Reported by: chckens Owned by: evands
Milestone: Adium 1.2.5 Component: Adium UI
Version: Severity: normal
Keywords: Cc:
Patch Status:

Description

If I click the "bookmark the current chat" toolbar button in an ordinary conversation window on my Jabber account (i.e. with a single other participant rather than an MUC room), a useless entry gets added to my contact list, i.e. double clicking on this new bookmark does nothing.

(Makes me wonder why there are separate toolbar buttons for Add Contact and Add Bookmark... shouldn't a single "Add to Contact List" suffice for both situations?)

Change History (5)

comment:1 Changed 12 years ago by Jordan

Milestone: Adium X 1.2.5

Good point... it should probably only work when there is more than one other person in the chat. Can we grey the button out unless the active tab is a MUC?

comment:2 Changed 12 years ago by Jordan

Summary: bookmark chat button "works" when it shouldn'tBookmark chat allows bookmarking of single user conversations

comment:3 Changed 12 years ago by Evan Schoenberg

Owner: changed from nobody to Evan Schoenberg
Status: newassigned

You might want to add another contact (say, one that your friend just told you about) using Add Contact, though I'm not sure that's a strong enough reason not to combine the buttons into one. In any case, the bug itself is simple here :)

comment:4 Changed 12 years ago by Evan Schoenberg

Resolution: fixed
Status: assignedclosed

(In [23055]) Only enable the bookmark toolbar item if we're in a group chat. Fixes #9335

comment:5 Changed 12 years ago by Evan Schoenberg

(In [23056]) merged [23055]: Only enable the bookmark toolbar item if we're in a group chat. Fixes #9335

Note: See TracTickets for help on using tickets.