Adium

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#8995 closed defect (fixed)

Contact joins a chat group - Speak the event aloud says "Null... Null" for everyone (?)

Reported by: zaphraud Owned by: evands
Milestone: Adium 1.2.2 Component: Adium Core
Version: Severity: normal
Keywords: speech speak event aloud null contact joins group chat Cc:
Patch Status:

Description

Steps to creating my situation: Install Adium 1.2.1 via upgrade

Enable voice notifications for "Contact signs on", speak event. Works great! Even reads aliases great, so no problem there. VERY, VERY useful feature.

Enable voice notifications for "Contact joins a group chat". Instead of hearing something along the lines of "Friendly User has joined the chat" or "Friendly user entered Friendliest Chatroom Ever" I hear the phrase "Null... Null" spoken. With about a half second pause.

If I had to take a totally wild guess I'd say this is a couple misplaced characters in the source code first, second, I'd guess someone changed the data structure and some of the subroutines didn't get updated on accident - but I haven't audited the code at all.

Change History (6)

comment:1 Changed 13 years ago by zaphraud

Addition information: Disabling "Speak name" causes the even to simply say "Null" only one time.

comment:2 Changed 13 years ago by Evan Schoenberg

Milestone: Adium X 1.2.2
Owner: changed from nobody to Evan Schoenberg
Status: newassigned

comment:3 Changed 13 years ago by Evan Schoenberg

Resolution: fixed
Status: assignedclosed

(In [22438]) Chat joined/left events are chat events which don't have an associated message; simply calling -[AIContactAlertsController isMessageEvent] is insufficient to know that a particular message can be displayed or spoken. Fixes #8995.

comment:4 Changed 13 years ago by Evan Schoenberg

(In [22439]) Merged [22438]: Chat joined/left events are chat events which don't have an associated message; simply calling is insufficient to know that a particular message can be displayed or spoken. Fixes #8995.

comment:5 Changed 13 years ago by zaphraud

Another workaround: Setting "Speak specific text" and specifying the string

%a entered chat

functions well enough to make this low-priority provided the workaround is known...

comment:6 Changed 13 years ago by zaphraud

Note: with that workaround enabled, when you go into a chatroom with a LOT of people already in it, be prepared to wait for a loooooooooooooonnng time as it reads off, one at a time, a list of *everyone* in the chatroom, even tho they did NOT just enter the chat and were, in fact, in the chatroom prior to your entry.

Note: See TracTickets for help on using tickets.