Adium

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#8816 closed defect (fixed)

[CBPurpleAccount purpleThread] may not be initialised

Reported by: BigBrownChunx Owned by: nobody
Milestone: Adium 1.2.1 Component: Plugin
Version: Severity: normal
Keywords: Cc: Evan Schoenberg
Patch Status: Accepted

Description

[CBPurpleAccount purpleThread] (in Plugins/Purple Service/CBPurpleAccount.m) may have not been initialised when called, if called before [CBPurpleAccount purpleAccount], causing 3rd party protocols to hang (if they dont override purpleThread method), since they can be loaded before PurplePlugin is loaded

Patch attached

Attachments (1)

CBPurpleAccount.diff (426 bytes) - added by Eion Robb 12 years ago.
Fix to init purpleThread if needed

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by Eion Robb

Attachment: CBPurpleAccount.diff added

Fix to init purpleThread if needed

comment:1 Changed 12 years ago by Jordan

Cc: Evan Schoenberg added
Milestone: Needs dev review

comment:2 Changed 12 years ago by Chris Forsythe

Milestone: Needs dev reviewAdium X 1.2.1

We should try to apply patches quickly, so putting on the next milestone.

comment:3 Changed 12 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [22272]) Initialize SLPurpleCocoaAdapter for CBPurpleAccount if needed when it is first accessed. Fixes #8816

comment:4 Changed 12 years ago by Evan Schoenberg

(In [22273]) merged [22272]: Patch from BigBrownChunx: Initialize SLPurpleCocoaAdapter for CBPurpleAccount if needed when it is first accessed. Fixes #8816

comment:5 Changed 12 years ago by Evan Schoenberg

Milestone: Adium X 1.2.1Adium X 1.2.2

comment:6 Changed 12 years ago by Evan Schoenberg

Milestone: Adium X 1.2.2Adium X 1.2.1

comment:7 Changed 12 years ago by Robert

Patch Status: Initially IncludedAccepted
Note: See TracTickets for help on using tickets.