Adium

Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#8757 closed enhancement (fixed)

Display alias in handle textfield by default

Reported by: jjay Owned by: nobody
Milestone: Adium 1.2.1 Component: Adium UI
Version: Severity: normal
Keywords: handle Cc:
Patch Status: Accepted

Description

By default in the jabber joint conf room, the handle is empty. I think it's a good idea to set the account alias by default in the Handle textField.

I made a patch (on the file Plugins/Purple Service/DCPurpleJabberJoinChatViewController.m) to do that.

jjay

Attachments (3)

alias_handle_patch.diff (582 bytes) - added by Merillon Jean-Jacques 12 years ago.
Patch to display alias in Handle field
alias_handle_patch_2.diff (509 bytes) - added by Merillon Jean-Jacques 12 years ago.
Patch to display placeholder alias in Handle field
alias_handle_patch_3.diff (760 bytes) - added by Merillon Jean-Jacques 12 years ago.
New patch solving the issue : The placeholder is not used when no handle is specified

Download all attachments as: .zip

Change History (20)

Changed 12 years ago by Merillon Jean-Jacques

Attachment: alias_handle_patch.diff added

Patch to display alias in Handle field

comment:1 Changed 12 years ago by Jordan

Milestone: Needs dev review

comment:2 Changed 12 years ago by Evan Schoenberg

Is there a reason that you accessed the information as you did versus [account displayName]?

I think this should be a placeholder string rather than the actual string value.

Changed 12 years ago by Merillon Jean-Jacques

Attachment: alias_handle_patch_2.diff added

Patch to display placeholder alias in Handle field

comment:3 Changed 12 years ago by Merillon Jean-Jacques

You're right. I added a new patch (alias_handle_patch_2.diff) with your comments ! thx

comment:4 Changed 12 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [22141]) Patch from jjay which shows the account's display name as placeholder text for the 'handle' field when joining a Jabber group chat. Thanks! Closes #8757

comment:5 Changed 12 years ago by Robert

1.2.1?

comment:6 Changed 12 years ago by Evan Schoenberg

Milestone: Needs dev reviewAdium X 1.2.1

Truth!

comment:7 Changed 12 years ago by Merillon Jean-Jacques

Could ou please re-open this ticket. There is a issue : the placeholder is not use when not handle is specified. I made a new patch to solve this issue (alias_handle_patch_2.diff)

comment:8 Changed 12 years ago by Merillon Jean-Jacques

In my last comment it's : alias_handle_patch_3.diff and not alias_handle_patch_2.diff

Changed 12 years ago by Merillon Jean-Jacques

Attachment: alias_handle_patch_3.diff added

New patch solving the issue : The placeholder is not used when no handle is specified

comment:9 Changed 12 years ago by Evan Schoenberg

(In [22175]) Further patch from jjay to use the display name, falling back on the formattedUID, as the handle in Jabber group chats. Fixes #8757

comment:10 Changed 12 years ago by Evan Schoenberg

Ah, that's good - I hadn't tested in another client and had assumed (incorrectly) that I was just seeing an Adium bug that the handle wasn't being displayed. Thanks :)

comment:11 Changed 12 years ago by Evan Schoenberg

Milestone: Adium X 1.2.1Adium X 1.2.2

comment:12 Changed 12 years ago by Evan Schoenberg

Milestone: Adium X 1.2.2Adium X 1.2.1

comment:13 Changed 12 years ago by rsmclane

Running Adium 1.2.1, I still seem to be having this issue. When I join a jabber group chat, my alias place holder is displayed but when I join the chat, it's not used.

comment:14 Changed 12 years ago by Merillon Jean-Jacques

Yes you're right ! I juste downloaded the latest adiu release (1.2.1) and the placeholder is not used :(

I think the latest patch alias_handle_patch_3.diff is not inclued in adium 1.2.1 !

evands am I right ?

comment:15 Changed 12 years ago by Merillon Jean-Jacques

I just verified, the last patch is in trunk but not in root/tags/AdiumX_1.2.1 :( The next release 1.2.2 solve this issue.

comment:16 Changed 12 years ago by Evan Schoenberg

(In [22466]) Merged [22175]: Further patch from jjay to use the display name, falling back on the forma ttedUID, as the handle in Jabber group chats. Fixes #8757

comment:17 Changed 11 years ago by Robert

Patch Status: Initially IncludedAccepted
Note: See TracTickets for help on using tickets.