Adium

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#8685 closed defect (fixed)

Text Entry Field in IM Window defaults too tall

Reported by: Julian BH Owned by: evands
Milestone: Adium 1.2 Component: Adium UI
Version: Severity: normal
Keywords: Cc:
Patch Status:

Description

The text entry field at the bottom of the IM window is a few pixels too tall every time I open the window. I can drag it shorter, to the minimum size, but when I open a new window it forgets my new setting.

Attachments (2)

Picture 4.png (23.9 KB) - added by Julian Bennett Holmes 13 years ago.
freshly opened window - text entry field is too tall
Picture 5.png (23.8 KB) - added by Julian Bennett Holmes 13 years ago.

Download all attachments as: .zip

Change History (11)

Changed 13 years ago by Julian Bennett Holmes

Attachment: Picture 4.png added

freshly opened window - text entry field is too tall

Changed 13 years ago by Julian Bennett Holmes

Attachment: Picture 5.png added

comment:1 Changed 13 years ago by Evan Schoenberg

Do you see this problem in Adium 1.1.x?

comment:2 Changed 13 years ago by Evan Schoenberg

(In [22035]) Added a debug log to investigate #8685, as it worksforme. Refs #8685

comment:3 Changed 13 years ago by Evan Schoenberg

Once it's available, please post debug logging here of opening the chat, fixing the height, closing the chat, then reopening it (and seeing that your change wasn't saved).

comment:4 Changed 13 years ago by batmanppc

Evan

I see this issue too but I just wrote it off as happening because I chose my font to be smaller than the default. Maybe try replicating by setting the default font size for the entry field?

comment:5 Changed 13 years ago by Evan Schoenberg

Milestone: Adium X 1.2
Owner: changed from nobody to Evan Schoenberg
Status: newassigned

By "once it's available" I clearly meant "once 1.2b6 is available" :P ...which it now is.

And... ah! Yes, with the font size set smaller, it starts off at a size larger than its minimum and refuses to save. I don't know why a deliberate lower limit was placed on the saved field size (actually, on the restored size, but it's the same effect), but I see no reason for it.

comment:6 Changed 13 years ago by Evan Schoenberg

Resolution: fixed
Status: assignedclosed

(In [22047]) Fixed the minimum text entry view height handling. There is no reason at all to arbitrarily restore it to a height of 20 if it is set to a height less than that; it should follow the needed text height. If no height has been set, calculate it using -[AIMessageViewController _textEntryViewProperHeightIgnoringUserMininum:]. Fixes #8685

comment:7 Changed 13 years ago by Evan Schoenberg

Scratch that on the debug logging. This should be fixed for 1.2b7 (or 1.2 final).

comment:8 Changed 13 years ago by Julian Bennett Holmes

This still isn't fixed in 1.2b8, as far as I can tell.

Here's the debug log you requested:

02:40:15: [AIChat: 4bb800 initForAccount] 02:40:15: chatWithContact: Added <<<AIChat: 0x4bb800>:<new>>> [{(

<AIChat: 0x4bb800>:<new>

)}] 02:40:15: purple openChat:<AIChat: 0x4bb800>:AIM.aniage8 for AIM.aniage8 02:40:15: imChatLookupFromConv: Creating julianstungun aniage8 02:40:15: -[AIMessageViewController chatParticipatingListObjectsChanged:]: 0, so not reloading (null) 02:40:15: Updating security details for <AIChat: 0x4bb800>:AIM.aniage8 02:40:20: purple closeChat:AIM.aniage8 02:40:20: closeChat: Removed <<<AIChat: 0x4bb800>:AIM.aniage8>> [{( )}] 02:40:21: [AIChat: 7777b80 initForAccount] 02:40:21: chatWithContact: Added <<<AIChat: 0x7777b80>:<new>>> [{(

<AIChat: 0x7777b80>:<new>

)}] 02:40:21: purple openChat:<AIChat: 0x7777b80>:AIM.aniage8 for AIM.aniage8 02:40:21: imChatLookupFromConv: Creating julianstungun aniage8 02:40:21: -[AIMessageViewController chatParticipatingListObjectsChanged:]: 0, so not reloading (null) 02:40:21: Updating security details for <AIChat: 0x7777b80>:AIM.aniage8 02:40:26: purple closeChat:AIM.aniage8 02:40:26: closeChat: Removed <<<AIChat: 0x7777b80>:AIM.aniage8>> [{( )}]

comment:9 Changed 13 years ago by Julian Bennett Holmes

This should be re opened and milestone set to 1.2.1 probably, as this isn't fixed in 1.2 final, at least for me. I'm not sure if this is happening for everyone, or just me - I can attach more debug logs if you'd like.

Note: See TracTickets for help on using tickets.