Adium

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#8459 closed defect (fixed)

Action renders asterisk (*) as part of URL's hyperlink at message end

Reported by: mash Owned by:
Milestone: Adium 1.3 Component: Message View
Version: Severity: minor
Keywords: action actions /me asterisk * link hyperlink URL Cc:
Patch Status:

Description

When displaying an action (/me) ending in a URL (in plain text, no included HTML hyperlinking), Adium's renderer includes the asterisk (*) as part of the URL in the automatic hyperlinking.

Example:
Someone (or I) sends:

/me goes to http://www.host.com/file


My effective display: *goes to http://www.host.com/file*

Change History (4)

comment:1 Changed 12 years ago by Jordan

Milestone: Adium X 1.2.1
priority: normallow
Severity: normalminor

Confirmed with 1.2svn

comment:2 Changed 12 years ago by Evan Schoenberg

Milestone: Adium X 1.2.1Adium X 1.2.2

comment:3 Changed 12 years ago by David Smith

Resolution: fixed
Status: newclosed

(In [22427]) This significantly reworks how /me is handled. In particular:

  • All special display is handled by CSS; This fixes #8459, and allows message styles to style /me as they choose.
  • A raw /me is sent over the wire. This fixes #8934.

Caveats (feedback *very* welcome, I'm a little hesitant on this)

  • Styles with custom Template.html files will show /me unstyled, without even the default * *
  • Some clients may not support /me (old versions of iChat don't, for example). Catering to these clients may prove quite tricky, as we would need to filter differently for display and transmit, and differently based on the receiver's protocol.
  • The design is not all that nice; in particular, filter plugins can't output html, so I had to output tokens and transform to html in the wkmv

comment:4 Changed 12 years ago by David Smith

Milestone: Adium X 1.2.2Adium X 1.3

This change is, in my opinion, too risky to go in 1.2.2. In particular, message style authors need some time to update.

Note: See TracTickets for help on using tickets.