Adium

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#8223 closed defect (fixed)

Mutually exclusive search/index in log viewer.

Reported by: spoonman Owned by: evands
Milestone: Adium X 1.1.4 Component: Logging
Version: Severity: normal
Keywords: search index Cc:
Patch Status:

Description

When I bring up the logs window, Adium begins to index the logs of the person I am looking at. One expects this, however when I perform a search using the Search Content field, the search is held in stasis while the indexing finishes. Once the indexing is complete my search is put through as normal. This is awkward because if you have not accessed a log in awhile you may have 500 odd entries to index, and that can take awhile. So an experience that should be fast - reference type - becomes boring and drawn out.

I am able to click through the logs just fine as it indexes, I am able to perform a find operation on any log I can click to, but the search field is effectively inaccessible most times.

Change History (5)

comment:1 Changed 13 years ago by Evan Schoenberg

When you start a search, indexing is immediately asked to pause. As soon as it finishes indexing the one current transcript in progress, the search executes.

Are you sure that it continues to index more than 1 transcript?

comment:2 Changed 13 years ago by Jordan

Milestone: Needs feedback from users
pending: 01

comment:3 in reply to:  1 Changed 13 years ago by Evan Schoenberg

Milestone: Needs feedback from usersAdium X 1.1.4
Owner: changed from nobody to Evan Schoenberg
Status: newassigned

Replying to evands:

When you start a search, indexing is immediately asked to pause. As soon as it finishes indexing the one current transcript in progress, the search executes.

Apologies; the above is how it was supposed to work, but it was apparently broken at some point.

comment:4 Changed 13 years ago by Evan Schoenberg

Resolution: fixed
Status: assignedclosed

(In [21449]) Fixed the interaction between searching and indexing such that a search is progressively done on the index logs so far as indexing takes place. Fixes #8223

comment:5 Changed 13 years ago by Evan Schoenberg

(In [21451])

  • Merged [21448]: Fixed a nasty bug in which the log index could be treated as 'corrupt' if the transcript viewer were opened, closed, and reopened in rapid succession, leading to either reindexing of all logs or some logs not being properly indexed. Also fixed a condition in which a search could lead to one or more logs not ever being indexed. Since it is likely that many indexes are currently missing some logs' contents, I've bumped the index version number to trigger a full reindex on first launch.
  • Merged [21449]: Fixed the interaction between searching and indexing such that a search is progressively done on the index logs so far as indexing takes place. Fixes #8223
Note: See TracTickets for help on using tickets.