Adium

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#8202 closed defect (fixed)

Contact dragging broken in Leopard

Reported by: Durandal64 Owned by: nobody
Milestone: Adium X 1.1.4 Component: Adium UI
Version: Severity: normal
Keywords: Cc:
Patch Status:

Description

I can't seem to drag contacts in the contact window to create meta-contacts in Leopard, regardless of window style. Command-drag doesn't work for borderless windows, and regular drag doesn't work for regular windows. When I drag, I just start selecting multiple contacts.

Change History (12)

comment:1 Changed 13 years ago by Jordan

Milestone: Adium X 1.1.4

This is fairly serious, and should probably be in 1.1.4...

comment:2 Changed 13 years ago by Zachary West

This bug confuses me greatly.

comment:3 Changed 13 years ago by Jordan

This also occurs in the accounts drawer when you get info a metacontact. I can no longer re-order accounts for preference of display picture and name via drag and drop.

comment:4 Changed 13 years ago by Jordan

On a whim I asked my buddy to see if he could drag and drop contacts in Adium (he is also using Leopard now), and it worked! I then grabbed the build from him and tried it on my machine, and again drag and drop worked fine. This was a build I made on September 15 of [20994], so something between then and now created this problem...

comment:5 Changed 13 years ago by Zachary West

Adium 1.1.2, which is [20844], has the problem.

Adium 1.1.1, which is [20585] does not have the problem.

Will investigate more.

comment:6 Changed 13 years ago by Zachary West

@evan: Did you compile 1.1.2/1.1.3 on Leopard? I think Peter compiled 1.1.1 on Tiger; the release of 1.1.1 drags fine, the same revision ([20585]) compiled myself on Leopard does not.

comment:7 Changed 13 years ago by David Smith

That sounds like a link-check at work. Search the appkit release notes for the phrase "linked on", and check if there's anything relevant (NSTableView or NSOutlineView, perhaps).

comment:8 Changed 13 years ago by Jordan

That would explain why my later revision of 1.2svn has working drag and drop while the earlier revision 1.1.2 release does not drag and drop; I compiled that build of 1.2svn on Tiger.

comment:9 Changed 13 years ago by Zachary West

Found it.

- (NSUInteger)hitTestForEvent:(NSEvent *)event inRect:(NSRect)cellFrame ofView:(NSView *)controlView {
   return NSCellHitContentArea;
}

in AIListCell.m will make drag and drop work. It looks like specifying the cell type will make this work (so I'll play around with that).

comment:10 Changed 13 years ago by Zachary West

Resolution: fixed
Status: newclosed

(In [21444]) Fix contact dragging on Leopard. By default, an NSCell returns (when enabled) NSCellHitTrackableArea, which causes it to be tracked instead of dragged. Fixes #8202.

comment:11 Changed 13 years ago by Zachary West

(In [21445]) Merged [21444]: Fix contact dragging on Leopard. By default, an NSCell returns (when enabled) NSCellHitTrackableArea, which causes it to be tracked instead of dragged. Fixes #8202.

comment:12 Changed 13 years ago by Evan Schoenberg

Awesome! :D

Note: See TracTickets for help on using tickets.