Adium

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#7919 closed enhancement (fixed)

Send text attributes (colour, font) in Yahoo! Group Chat

Reported by: iesenta Owned by: nobody
Milestone: Adium 1.3 Component: Service/Yahoo
Version: Severity: normal
Keywords: group chat Cc:
Patch Status: Accepted

Description

This patch enable sending out attributed strings in Yahoo! Japan chat rooms. It sends out any string with length as attributed, whichever the buddy receiving the string is on your buddy list. This patch tested well by my friends for the last two years. No problem occurred.

EnablingAttributedStringInYahooGroupChat.diff

Index: Plugins/Purple Service/ESPurpleYahooAccount.m
===================================================================
--- Plugins/Purple Service/ESPurpleYahooAccount.m	(revision 20741)
+++ Plugins/Purple Service/ESPurpleYahooAccount.m	(working copy)
@@ -123,7 +123,11 @@
 #pragma mark Encoding
 - (NSString *)encodedAttributedString:(NSAttributedString *)inAttributedString forListObject:(AIListObject *)inListObject
 {	
-	if (inListObject) {
+	//iesenta change a line
+	//if (inListObject) {
+	int l = [inAttributedString length];
+		
+	if (inListObject || l) {
 		return [AIHTMLDecoder encodeHTML:inAttributedString
 								 headers:NO
 								fontTags:YES

Change History (7)

comment:1 Changed 12 years ago by Colin Barrett

Patch Status: Initially IncludedNeeds Discussion

Is it normal for inListObject to be nil? That seems a little odd to me.

Also, were I to check this in, I would just remove the check on inListObject entirely.

Other than that, looks good. Marking as "needs discussion" per the inListObject being nil issue.

comment:2 Changed 12 years ago by Evan Schoenberg

(In [21012]) Expanded documentation on -[AIAccount encodedAttributedString:forListObject:]. Refs #7919

comment:3 Changed 12 years ago by Evan Schoenberg

And yes, this should be returning HTML in all cases; I've verified the Yahoo prpl handles this properly. It might actually be true now that all libpurple prpls should always be getting HTML; this was not the case years ago when our code was first written.

comment:4 Changed 12 years ago by Eric Richie

Milestone: Needs dev review

comment:5 Changed 12 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [22402]) I said on 9/16/07 in #7919 that this change is okay; I trust myself. Patch from iesenta to send HTML to Yahoo, allowing rich text messages to be sent, as the protocol and prpl now handle that. Fixes #7919

comment:6 Changed 12 years ago by Evan Schoenberg

Milestone: Needs dev reviewAdium X 1.3
Patch Status: Needs DiscussionAccepted

comment:7 Changed 12 years ago by Robert

Summary: Text attribute(color,font) send in Yahoo! Group ChatSend text attributes (colour, font) in Yahoo! Group Chat
Note: See TracTickets for help on using tickets.