Adium

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#7769 closed defect

Shadow behind transparent chat window isn't updated

Reported by: yorn Owned by: nobody
Milestone: Component: Adium UI
Version: Severity: normal
Keywords: Cc:
Patch Status:

Description

I installed Safari 3 beta, got hit by #7164 so I compiled from SVN (since the bug is already fixed there). Now it occured to me that transparency works fine now, but the shadow isn't updated at message sending or retrieval. Forcing the shadow to be repainted (by resizing the window or taking it's focus) fixes the problem, but it occurs again when a new message is sent/received. You can see this effect on the attached screenshot; See the message "whoa this message is ghosted! :o", a few pixels below you see the same message "ghosting". This happend because the text was there before the message "I bet this should not happen" appeared and moved it up. The "ghosting" happens to both text and images.

I believe this can be fixed by forcing the shadow to be repainted everytime something changes in the message area

Attachments (2)

Screenshot.png (35.2 KB) - added by yorn 12 years ago.
The ghosting effect in action
Picture 3.png (297.4 KB) - added by jchang 12 years ago.

Download all attachments as: .zip

Change History (19)

Changed 12 years ago by yorn

Attachment: Screenshot.png added

The ghosting effect in action

comment:1 Changed 12 years ago by CC

Ahh. It's a little hard to see if your LCD screen brightness isn't turned up high enough.

comment:2 Changed 12 years ago by jchang

i'm seeing this as well.

comment:3 Changed 12 years ago by David Smith

Resolution: fixed
Status: newclosed

(In [20840]) Invalidate the window shadow when using a transparent background. Fixes #7769

comment:4 Changed 12 years ago by David Smith

Milestone: Adium X 1.1.2

comment:5 Changed 12 years ago by jchang

i'm still seeing this in 1.1.2

Changed 12 years ago by jchang

Attachment: Picture 3.png added

comment:6 in reply to:  description Changed 12 years ago by yorn

Well sorry, the bug isn't entirely fixed, shadow is updated after sending/receiving messages, but not after changing the tab..

comment:7 Changed 12 years ago by David Smith

Milestone: Adium X 1.1.2Adium X 1.1.3
Resolution: fixed
Status: closedreopened

comment:8 Changed 12 years ago by bigDee

email me at bigDee2007@… if there is ever a fix for this

comment:9 Changed 12 years ago by yorn

I just figured that the shadow also isn't updated after scrolling, and when typing very long messages (the input box gets higher, thus moving the text up, but not the shadow)

comment:10 Changed 12 years ago by Colin Barrett

It's kind of ridiculous that we have to invalidate the shadow ourselves. "Perf win" for webkit? Perhaps. Annoying for us? Definitely.

comment:11 Changed 12 years ago by Evan Schoenberg

The old solution overrode drawRect: and invalidated it; this was effective. It appears WebKit is no longer calling drawRect to draw a WebView :P A perusal of the source should be able to indicate the appropriate method to override.

comment:12 Changed 12 years ago by Evan Schoenberg

I can't figure out how WebView draws based on the source code.

comment:13 Changed 12 years ago by Colin Barrett

If they're not using drawRect, they are probably just drawing "directly" to the CGContext for that view.

We should file a bug with Apple -- they should at least be calling the drawRect: for their WebView, even if their implementation does nothing.

comment:14 Changed 12 years ago by Evan Schoenberg

Milestone: Adium X 1.1.3Waiting on Apple

Would somebody please file a bug with the webkit team on this issue? I believe David talked with someone about it; a link to the ticket would be nice if one exists.

comment:15 Changed 12 years ago by Carlos Morales

comment:16 Changed 11 years ago by Zachary West

Status: newclosed

Closing all waiting on apple tickets. These just take up space, and are largely ignored anyway. Any functionality we need but cannot add due to apple is a good radar to file, but we are not apple's tracker.

comment:17 Changed 11 years ago by (none)

Milestone: Waiting on Apple

Milestone Waiting on Apple deleted

Note: See TracTickets for help on using tickets.