Adium

Opened 15 years ago

Closed 12 years ago

Last modified 12 years ago

#758 closed enhancement (fixed)

Sending the entire away message to Growl when a contact goes away

Reported by: Diatribe Owned by: nobody
Milestone: Adium 1.2 Component: Adium UI
Version: Severity: normal
Keywords: growl away Cc:
Patch Status: Accepted

Description

Sending the entire away message to Growl when a contact goes away would be great to have as one wouldn't have to check the away after the notification anymore.

Attachments (1)

growl_show_messages.diff (1.1 KB) - added by Jay Goodman Tamboli 13 years ago.
quickie patch to include status messages in Growl notifications

Download all attachments as: .zip

Change History (16)

comment:1 Changed 15 years ago by bcirrel

I second that request. It would probably appear as a separate message just like in the message view but it would be awesome nonetheless.

comment:2 Changed 14 years ago by Jayphil@…

Count me in for this as well. Would be a nice option.

comment:3 Changed 14 years ago by Diatribe

I guess this also belongs in the events survey.

The only problem I see here is that if the contact has a script that changes his or her away frequently it would be pretty annoying. The solution I see would be an option to only send the first away message and not away message changes.

comment:4 Changed 14 years ago by Dan

Booya. I was just about to request this. Sending the first away message would be just fine. I hope to see it soon.

Dan

comment:5 Changed 14 years ago by eroger@…

I agree with Diatribe that it can be annoying, but would modify his suggestion to allow for two different Growl notifications - one with no away message at all, like the current one, and the other to have the whole away message on any state change.

comment:6 Changed 14 years ago by Diatribe

Then I guess we'd need three options, no away message, only for the first away and for every change.

Although I'd still say that EVERY change would be bad. Imagine someone using a Safari site away script. This would be annoying as hell. One possibility would be a timer to only send away message changes when they're over 10 mins. apart or so. Don't know how feasible this is to implement but this would solve that problem nicely.

comment:7 Changed 14 years ago by patr1ck

Component: Adium CoreAdium UI
field_haspatch: 0
Keywords: growl away added
Type: defectenhancement

I believe this belongs under UI as opposed to core, and is definitely an enhancement and not a defect.

comment:8 Changed 14 years ago by ryandesign

This whole discussion should apply not only to away messages but also to "here" messages.

comment:9 Changed 14 years ago by Seb Payne

Milestone: Sometime after 1.0

This may be looked at after 1.0 but for the moment, it will be left.

Changed 13 years ago by Jay Goodman Tamboli

Attachment: growl_show_messages.diff added

quickie patch to include status messages in Growl notifications

comment:10 Changed 12 years ago by Zachary West

Milestone: Good idea for "later"Adium X 1.2
Patch Status: Needs Dev Review
pending: 0

comment:11 Changed 12 years ago by Evan Schoenberg

The only problem with this patch - and the reason the message isn't included generally - is that the status message is not always available as soon as the status changes. For example, in AIM, we find out that the person went 'Away' and then, a moment later, learn what the status message is. At least, this is how it was a while back. Does this patch behave properly for AIM contacts going away?

comment:12 Changed 12 years ago by Jay Goodman Tamboli

I see away messages for AIM contacts going away. I haven't paid close enough attention to know whether it picks up the away message in every case, and I imagine it will not notify if someone changes their away message after going away. But it does seem to use the away message for AIM contacts when they initially go away. I don't know enough about the protocol to tell whether this is always the case, though.

comment:13 Changed 12 years ago by Zachary West

This patch behaves correctly when AIM contacts go away.

comment:14 Changed 12 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [20878]) Patch from jtamboli which shows status messages in Growl notifications when they are present. This wouldn't have worked a long time ago, because of delays between status change and the message being available, but it seems that the modern status API handles it just fine. Thanks! Fixes #758.

comment:15 Changed 12 years ago by Robert

Patch Status: Needs Dev ReviewAccepted
Note: See TracTickets for help on using tickets.