Adium

Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#6775 closed defect (fixed)

Tab length is sometimes too short

Reported by: boredzo Owned by: nobody
Milestone: Adium X 1.1 Component: Adium UI
Version: Severity: normal
Keywords: psmtabbarcontrol tab width length Cc:
Patch Status:

Description

Screenshot says at all, except that the complete title of the tab is “zacw”.

Attachments (5)

boredzo-tabtooshort.png (170.3 KB) - added by Peter Hosey 13 years ago.
Screenshot of two tabs, the second of which is too short for its title.
tabs.png (1.8 KB) - added by Zachary West 13 years ago.
"Eric" tab too short.
Tab too short.png (3.9 KB) - added by Miikka 12 years ago.
Tab is too short
Picture 1.png (8.7 KB) - added by Jordan 12 years ago.
Normal size tabs
Picture 2.png (7.7 KB) - added by Jordan 12 years ago.
exact same tabs, different order and one of them is too large.

Download all attachments as: .zip

Change History (15)

Changed 13 years ago by Peter Hosey

Attachment: boredzo-tabtooshort.png added

Screenshot of two tabs, the second of which is too short for its title.

comment:1 Changed 13 years ago by Zachary West

I've experienced this also with the labels "Eric" and "Me".

Changed 13 years ago by Zachary West

Attachment: tabs.png added

"Eric" tab too short.

comment:2 Changed 13 years ago by Jordan

Has this been repaired in recent revisions? I haven't seen it happen in at least a couple weeks...

comment:3 Changed 13 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

Yeah, I believe this has been fixed. Please reopen if you can reproduce it now.

Changed 12 years ago by Miikka

Attachment: Tab too short.png added

Tab is too short

comment:4 Changed 12 years ago by Miikka

I would like to propose this to be reopened. I just upgraded to Adium 1.1 Beta 5 and noticed that I am suffering from this. I attached the picture "Tab is too short" to explain this - the nick name is two Chinese characters ... and only the first one is shown while the second character is replaced by "...".

comment:5 Changed 12 years ago by Zachary West

pending: 0
Resolution: fixed
Status: closedreopened

comment:6 Changed 12 years ago by David Smith

See #7484 and #7488

comment:7 Changed 12 years ago by Jordan

I'm also encountering the situation where a tab length is sometimes too long. See the attached screenshots for details.

I think this might be part of the same issue, if not let me know and I'll open another ticket for this.

Picture 2 shows the problem. Picture 1 shows that with the exact same tabs open the sizing changes depending on location of the tab.

Changed 12 years ago by Jordan

Attachment: Picture 1.png added

Normal size tabs

Changed 12 years ago by Jordan

Attachment: Picture 2.png added

exact same tabs, different order and one of them is too large.

comment:8 Changed 12 years ago by Evan Schoenberg

Ah. Another instantiation of the size-to-fit algorithm not being Right, as discussed in (Adium-devl) Should tabs size-to-fit?

comment:9 Changed 12 years ago by Evan Schoenberg

Resolution: fixed
Status: reopenedclosed

(In [20522]) PSMTabBarControl [175]: Size-to-fit for tabs now works properly when tabs are overflowing. Fixes #6775

comment:10 Changed 12 years ago by Evan Schoenberg

(In [20523]) merged [20522]: PSMTabBarControl [175]: Size-to-fit for tabs now works properly when tabs are overflowing. Fixes #6775

Note: See TracTickets for help on using tickets.