Adium

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#6732 closed defect (fixed)

Temporary files should be deleted sooner than later (e.g. when closing a chat)

Reported by: evands Owned by:
Milestone: Adium X 1.1 Component: Message View
Version: Severity: minor
Keywords: Cc:
Patch Status:

Description (last modified by Evan Schoenberg)

When a chat closes, the temporary files it has written in -[AIWebKitMessageViewController _updateUserIconForObject:] should be deleted immediately.

-[AIWebKitMessageViewController _webKitUserIconPathForObject:] should be using a fully unique string so there's no chance of cross-chat interference.

Inspired by #6724.

Change History (5)

comment:1 Changed 13 years ago by Evan Schoenberg

Description: modified (diff)

comment:2 Changed 13 years ago by Paul Hammant

Is it also possible to make Adium share cached images where they are completely identical while in use and prior to deletion? 100's of the same TIFFs make no sense.

If this truly cannot be done, can Adium make symbolic links instead of writing real TIFFs?

comment:3 Changed 13 years ago by Evan Schoenberg

Related to #4711

comment:4 Changed 13 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [19459]) This reuses cached images across chats if appropriate (e.g. for an account when that account is in multiple chats [common] or a contact is in multiple chats [less common]) and deletes temporary images as soon as they are not being used. Images are also written out as png instead of tiff.

Temporary images would be cleared when the chat closes except that AIWebKitMessageViewController is never deallocated at present do to the leak of AIMessageTabViewItem I described earlier on adium-devl.

Finally, status icons, which may be used by some message styles, are only written out to disk if they are actually going to be used.

Fixes #4711. Fixes #6732. Both techincally pending the leak fix, however, but we won't release 1.1 without hunting that down.

comment:5 Changed 13 years ago by Zachary West

Milestone: Adium X 1.2Adium X 1.1
Note: See TracTickets for help on using tickets.