Adium

Opened 13 years ago

Closed 13 years ago

Last modified 11 years ago

#6664 closed defect (fixed)

windows pop up when people sign off, when using OTR

Reported by: jwz Owned by: nobody
Milestone: Adium X 1.1.4 Component: Adium Core
Version: Severity: normal
Keywords: status message causes pop up window encryption Cc:
Patch Status:

Description

I have Adium set to open a new window when someone messages me. The window often (but not always) opens when someone *signs off*, even if they haven't said anything. I think it only happens when: I have been talking to someone using OTR; I have closed the window; and then they sign off. But I'm not sure it *always* happens in that situation.

I suspect the "no longer using encryption" message that comes just before the "disconnected" message is what is making the window pop up:

user_foo 8:31 PM blah user_foo 6:39 AM user_foo is no longer using encryption; you should cancel encryption on your side. user_foo 6:39 AM user_foo disconnected

Attachments (2)

log.txt (95.8 KB) - added by Jamie Zawinski 13 years ago.
debug log
log.2.txt (79.8 KB) - added by Jamie Zawinski 13 years ago.
log from adium 1.1.3b4

Download all attachments as: .zip

Change History (15)

comment:1 Changed 13 years ago by Jordan

Component: Adium UIOTR
Keywords: status message causes pop up window encryption added
Milestone: Needs feedback from users

Please try installing the Adium 1.0.3 beta since it will enable debug logging. You can access and enable the log by going to the Adium menu, then 'debug window'.

Please check out this page for more information and attach any useful logs you can here (console and debug if possible) during the timespan of this bug occurence.

Thanks!

comment:2 Changed 13 years ago by Jamie Zawinski

I am using 1.0.3 beta. I had been talking to "ioerrortype23" on AIM using OTR. I closed the window; a while later, he disconnected, and the window popped up again, without him ever having actually said anything:

4:25 PM he typed something (some time after that) I closed the window 5:21 PM "io error type23 is no longer using encryption; you should cancel encryption on your side." 5:21 PM "Jacob disconnected"

I'll attach the debug log since 4:21 PM.

Changed 13 years ago by Jamie Zawinski

Attachment: log.txt added

debug log

comment:3 Changed 13 years ago by Jordan

Milestone: Needs feedback from usersNeeds Feedback - Received

comment:4 Changed 13 years ago by Zachary West

I wouldn't call this a "bug" per se - since it's basically designed to do this. A status message occurs to a chat that currently isn't open, so it opens one.

comment:5 Changed 13 years ago by Jamie Zawinski

The behavior is inconsistent.

If I'm not using encryption, and someone signs off, their window does not pop up.

If I am using encryption, and someone signs off, *sometimes* the window pops up and sometimes it does not. (I'm guessing the difference is in how they exited, but I don't really know.)

Popping up the window to tell me that the person has logged off is not useful.

Popping up the window to tell me that they have stopped using encryption is not useful. (I will care about that the next time either they or I type something, but it's certainly of no interest before then.)

So, yeah, I'd call this a bug, based solely on the facts that it's A) annoying, B) not useful, and C) inconsistent.

comment:6 Changed 13 years ago by Evan Schoenberg

Milestone: Needs Feedback - ReceivedAdium X 1.1.1
pending: 0

comment:7 Changed 13 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [20599]) Open display encryption messages for a chat if it's already open; this isn't information which is needed if it's not. Fixes #6664

comment:8 Changed 13 years ago by Evan Schoenberg

(In [20600]) Merged [20599]: Only display encryption messages for a chat if it's already open; this isn't information which is needed if it's not. Fixes #6664

comment:9 Changed 13 years ago by Jamie Zawinski

For what it's worth, this is still happening in 1.1.2:

A window I had closed hours before popped back up saying:

XYZ is no longer using encryption; you should cancel encryption on your side. XYZ disconnected

Changed 13 years ago by Jamie Zawinski

Attachment: log.2.txt added

log from adium 1.1.3b4

comment:10 Changed 13 years ago by Zachary West

Milestone: Adium X 1.1.2Adium X 1.1.4
Resolution: fixed
Status: closedreopened

Ah, looks like the fix was done in the wrong spot.

The "has ended OTR" stuff looks like it's from display_otr_message(). This, however, is after a new chat is created for the message. It realizes this isn't a message worth opening a chat for, but there's already a chat, so it prints it anyway.

I NSLog()d all the -chatForContact: stuff in AdiumOTREncryption.m and none of it is being executed. Where is it making the chat at? Who knows!

comment:11 Changed 13 years ago by Evan Schoenberg

Resolution: fixed
Status: reopenedclosed

(In [21202]) This should finish fixing reopening of chats by certain OTR messages about which we don't care for a closed chat. Fixes #6664

comment:12 Changed 13 years ago by Evan Schoenberg

(In [21203]) Merged [21202]: This should finish fixing reopening of chats by certain OTR messages about which we don't care for a closed chat. Fixes #6664

comment:13 Changed 11 years ago by Zachary West

Component: OTRAdium Core

Removing 'OTR' component.

Note: See TracTickets for help on using tickets.