Adium

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#6430 closed defect (fixed)

Memory leak due to double gaim_init_msn_plugin()

Reported by: MatsMattsson Owned by: nobody
Milestone: Adium X 1.0.1 Component: None
Version: Severity: normal
Keywords: Cc:
Patch Status:

Description

gaim_init_msn_plugin() is called twice in 'Plugins/Gaim Service/adiumGaimCore.m' resulting in that some command tables are alloced twice (those alloced on the first call are leaked).

I haven't found a reason for initializing the msn-plugin twice, but my search through the logs have been limited.

PS. Is there an easy way to see when a piece of code was introduced to a file? E.g. displaying all diffs for all revisions.

Attachments (1)

gaim_init_msn_plugin.patch (434 bytes) - added by MatsMattsson 13 years ago.

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by MatsMattsson

Attachment: gaim_init_msn_plugin.patch added

comment:1 Changed 13 years ago by Evan Schoenberg

Great work with the leak hunting :)

svn blame (also known as svn annotate and svn praise, but blame is more fun) shows the revision at which each line was last modified. Is that what you're looking for?

comment:2 Changed 13 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [18997]) Patch from MatsMattsson which removes a double call to gaim_init_msn_plugin(), fixing a leak. Fixes #6430

comment:3 Changed 13 years ago by Evan Schoenberg

(In [18998]) Merged [18997]: Patch from MatsMattsson which removes a double call to gaim_init_msn_plugin(), fixing a leak. Fixes #6430

comment:4 Changed 13 years ago by Evan Schoenberg

Milestone: Adium X 1.0.1
Note: See TracTickets for help on using tickets.