Adium

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#6429 closed defect (fixed)

Memory leak in jabber_parser_element_start_libxml

Reported by: MatsMattsson Owned by: nobody
Milestone: Adium X 1.0.1 Component: None
Version: Severity: normal
Keywords: Cc:
Patch Status:

Description

A locally alloced char *attrib in libgaim/src/protocols/jabber/parser.c:jabber_parser_element_start_libxml is only freed for attributes "id" and "version", anything else will result in a leak.

This code seem to be called for parsing network data, i.e. it can not be argued that those are the only cases.

I have added an else clause in this patch that frees the alloced memory if neither handled attribute name was matched.

Attachments (1)

jabber_parser_element_start_libxml.patch (418 bytes) - added by MatsMattsson 14 years ago.
Possible solution

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by MatsMattsson

Possible solution

comment:1 Changed 14 years ago by Evan Schoenberg

Patch committed upstream to libgaim.

comment:2 Changed 14 years ago by Evan Schoenberg

Milestone: Adium X 1.0.1

comment:3 Changed 14 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [18999]) Libgaim r 392, which has the patch in #6429 from MatsMattsson to fix a memory leak in jabber_parser_element_start_libxml(). Patch was also committed upstream. Fixes #6429

comment:4 Changed 14 years ago by Evan Schoenberg

(In [19000]) Merged [18999]: Libgaim r 392, which has the patch in #6429 from MatsMattsson to fix a memory leak in jabber_parser_element_start_libxml(). Patch was also committed upstream. Fixes #6429

Note: See TracTickets for help on using tickets.