Adium

Opened 13 years ago

Closed 13 years ago

Last modified 11 years ago

#6424 closed defect (fixed)

Memory leak when using OTR encrytion

Reported by: MatsMattsson Owned by: nobody
Milestone: Adium X 1.0.1 Component: Adium Core
Version: Severity: normal
Keywords: leak Cc:
Patch Status:

Description

Each received (unencrypted) message is leaked.

-[AdiumOTREncryption decryptIncomingMessage:FromContact:onAccount:] does not call otrl_message_free(newMessage).

Attachments (2)

otr.patch (402 bytes) - added by MatsMattsson 13 years ago.
Suggested patch.
otr2.patch (1.1 KB) - added by MatsMattsson 13 years ago.
One more leak.

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by MatsMattsson

Attachment: otr.patch added

Suggested patch.

Changed 13 years ago by MatsMattsson

Attachment: otr2.patch added

One more leak.

comment:1 Changed 13 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [19018]) Fix two leaks in the OTR component. The unencrypted form of each received encrypted message was previously leaked, and there was a leak when requesting an encrypted chat.

Two more great fixes by MatsMattsson! Closes #6424.

comment:2 Changed 13 years ago by Evan Schoenberg

(In [19019]) Merged [19018]: Fix two leaks in the OTR component. The unencrypted form of each received encrypted message was previously leaked, and there was a leak when requesting an encrypted chat.

Two more great fixes by MatsMattsson! Closes #6424.

comment:3 Changed 13 years ago by Evan Schoenberg

Milestone: Adium X 1.0.1

comment:4 Changed 11 years ago by Zachary West

Component: OTRAdium Core

Removing 'OTR' component.

Note: See TracTickets for help on using tickets.