Adium

Opened 13 years ago

Closed 8 years ago

Last modified 8 years ago

#6373 closed enhancement (fixed)

Ability to change what the "iTunes" status does

Reported by: pphaneuf Owned by:
Milestone: Adium 1.5 Component: Adium Core
Version: 1.0 Severity: normal
Keywords: Cc:
Patch Status: Accepted

Description

It'd be nice to be able to change what the builtin "♫ iTunes" status does. I managed by creating my own custom status (I preferred "artist - track" to "track - artist"), but it looks a bit silly.

It is a bit strange that the builtin status has this "special treatment", no? I guess it's so that it's easily discoverable, but I wonder if bugfixes like that for #4981 will also work for other normal "available" custom statuses, say? Maybe a pre-filled custom status at installation would do the trick?

Attachments (4)

iTunesTokens.png (80.6 KB) - added by pks 8 years ago.
iTunesTokens.hgbundle (21.0 KB) - added by pks 8 years ago.
Fixed typo
iTunesTokensRevised.png (83.0 KB) - added by pks 8 years ago.
iTunesTokensRevised.hgbundle (21.6 KB) - added by pks 8 years ago.
Status now updating on change

Download all attachments as: .zip

Change History (17)

comment:1 Changed 13 years ago by edr1084

  • Milestone set to Good idea for "later"

comment:2 Changed 12 years ago by phlops

A nice way to go about this may be to put a table row in the Status prefs for the iTunes status that allows people to configure the order of the various iTunes tokens. I too would like to see artist come before track, but of course this is an arbitrary preference.

comment:3 Changed 12 years ago by kiel

  • Patch Status set to None
  • pending set to 0

If you open the "com.adiumx.adiumx" preference file located in ~/Library/Preferences/ with Property List Editor or TextEdit, you will find the key "Current Track Format". The value of this key is currently "" (that is, empty). If you replace the empty value for this key with "%_artist - %_track" (or any other sequence of iTunes token you wish), you will find that you can customise the iTunes status. This also affects the value given by the %_itunes token.

If you need help with this, please let me know. I'm more than happy to help. I will leave this ticket to the ticketing task force to close or whatever.

comment:4 Changed 12 years ago by djmori

comment:5 Changed 11 years ago by Jabronimus

I tried following the above steps, but I could not find the "com.adiumx.adiumx" file that you were referring to. Perhaps it is in another location?

Thanks in advance.

comment:6 Changed 9 years ago by Robby

  • Owner nobody deleted

Changed 8 years ago by pks

Changed 8 years ago by pks

Fixed typo

comment:7 Changed 8 years ago by sphynx

  • Component changed from None to Adium Core
  • Patch Status set to Needs Dev Review

comment:8 Changed 8 years ago by sphynx

  • Patch Status changed from Needs Dev Review to Needs Changes by Author

Thanks for the patch again, pKs! There are a couple of things I would do differently though.

First, I still think the text field should be a bit bigger. Maybe even multi-line (though that might not be possible for NSTokenFields). Something simple as "%_track by %_artist from %_album" already doesn't fit, and dragging something to the end is not possible if it overflows.

Also, it seems to be empty by default. Wouldn't it be better to make it "♫ %_track - %_artist" (or whatever the default is now)?

Lastly, it doesn't seem to update my status immediately when I change the format, should it do that?

Changed 8 years ago by pks

comment:9 Changed 8 years ago by pks

Changed layout (borrowed from System Preferences.app).
Fallback is displayed if token field would be empty.

comment:10 Changed 8 years ago by Robby

  • Milestone changed from Good ideas for later to Adium 1.5
  • Patch Status changed from Needs Changes by Author to Needs Dev Review

Changed 8 years ago by pks

Status now updating on change

comment:11 Changed 8 years ago by Robby

  • Patch Status changed from Needs Dev Review to Accepted

pks committed his patch here: http://hg.adium.im/adium/rev/e1fd671fd78c. :)

comment:12 Changed 8 years ago by Robby

  • Resolution set to fixed
  • Status changed from new to closed

comment:13 Changed 8 years ago by Robert Vehse

(In 82094bea5eef) Changelog improvements, add mention #6373. Refs #6373.

Note: See TracTickets for help on using tickets.