Adium

Opened 14 years ago

Closed 13 years ago

Last modified 12 years ago

#6287 closed defect (fixed)

Spotlight does not match the contents of chat transcripts

Reported by: boredzo Owned by: nobody
Milestone: Adium X 1.0.3 Component: Logging
Version: Severity: major
Keywords: spotlight metadata query content search kMDItemTextContent regression Cc: patches@…
Patch Status: Accepted

Description

Steps to reproduce

  1. Turn on logging on the General pane of Adium's Preferences.
  2. Chat. Remember any substring of any message of the chat.
  3. Invoke any Spotlight front-end (the menu item, ⌘-opt-space, NotLight, Blip, HoudahSpot, mdfind, SpotlightFS).
  4. Search for the previously-remembered substring.

Expected results

At least one match.

Actual results

Big duck egg.

Notes

Reported by a user via the feedback address, and tangentially by #6251.

I, boredzo, can reproduce this bug using the steps above.

Attachments (2)

patch6287.diff (959 bytes) - added by Paul Livesey 14 years ago.
Patch to fix #6287
Copyright.patch (284 bytes) - added by Paul Livesey 14 years ago.
Addition of my name to Copyright.txt

Download all attachments as: .zip

Change History (18)

comment:1 Changed 14 years ago by David Smith

Keywords: regression added
Milestone: Adium X 1.0.2

We should really fix this, particularly considering spotlight-friendliness was one motivation for switching log formats in the first place.

comment:2 in reply to:  1 Changed 14 years ago by Chris Forsythe

Severity: normalblocker

Replying to Catfish_Man:

We should really fix this, particularly considering spotlight-friendliness was one motivation for switching log formats in the first place.

Good enough for me, blocking 1.0.2 on this

comment:3 Changed 14 years ago by Paul Livesey

This is an easy fix. There is a small mistake inthe XPath expression that populates the kMDItemTextContent field for the spotlight query.

If there's another version of the spotlight plugin on the machine it MAY be used instead of the new and improved one. The easy way to check for this is to run a spotlight query from the command line and check for any conflicts with the importer.

mdimport -f -d4 <chatlog file to search>

The line just before the meta data is returned :-

2007-03-11 02:03:33.253 mdimport[417] Import '/Users/xxxx/test.chatlog' type 'com.adiumx.xmllog' using 'file :localhost/Users/xxxx/Library/Spotlight/AdiumSpotlightImporter.mdimporter/'

is not always believable, check for conflilcts in the early debug output.

A line something like :-

2007-03-11 02:03:33.115 mdimport[417] Plugin 'Spotlight/AdiumSpotlightImporter.mdimporter/ -- /Users/xxxx/adium/build/Development/Adium.app/Contents/Library/' UUID already claimed by 'file :localhost/Users/xxxx/Library/Spotlight/AdiumSpotlightImporter.mdimporter/'

is a sign of trouble. Delete (if possible) the old importer and try again.

A patch for this problem is included.

Changed 14 years ago by Paul Livesey

Attachment: patch6287.diff added

Patch to fix #6287

comment:4 Changed 14 years ago by Eric Richie

Cc: feedback@… added
field_haspatch: 01

comment:5 Changed 14 years ago by Colin Barrett

Is there any reason this shouldn't be checked in? The fix looks fine to me (pending testing).

comment:6 Changed 14 years ago by Colin Barrett

Milestone: Adium X 1.0.2Needs dev review

comment:7 Changed 14 years ago by Evan Schoenberg

I don't know my XPaths -- that's Graham's line there originally -- but if this fixes the issue it sounds good to me.

comment:8 Changed 14 years ago by Colin Barrett

Cc: patches@… added; feedback@… removed

comment:9 Changed 14 years ago by Colin Barrett

plivesey: The fix looks good, could you provide your real name (or if you are extremely uncomfortable with that, a suitable pen-name, although we would really prefer real ones) for inclusion in Copyright.txt?

Changed 14 years ago by Paul Livesey

Attachment: Copyright.patch added

Addition of my name to Copyright.txt

comment:10 Changed 14 years ago by Evan Schoenberg

Patch Status: OK; Needs Check-In

comment:11 Changed 14 years ago by Evan Schoenberg

Milestone: Needs dev reviewAdium X 1.0.3

comment:12 Changed 13 years ago by Eric Richie

Milestone: Adium X 1.0.3Adium X 1.1

comment:13 Changed 13 years ago by Eric Richie

Milestone: Adium X 1.1Adium X 1.0.3

comment:14 Changed 13 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [19318]) Patch from Paul Livesey which fixes import of chat logs via Spotlight. Fixes #6287

comment:15 Changed 13 years ago by Evan Schoenberg

(In [19319]) Merged [19318]: Patch from Paul Livesey which fixes import of chat logs via Spotlight. Fixes #6287

comment:16 Changed 12 years ago by Robert

Patch Status: OK; Needs Check-InAccepted
pending: 0
Note: See TracTickets for help on using tickets.