Adium

Opened 13 years ago

Closed 13 years ago

#6190 closed enhancement (fixed)

Move Accounts to the left of the prefs window

Reported by: cbarrett Owned by: cbarrett
Milestone: Adium X 1.1 Component: Adium UI
Version: Severity: normal
Keywords: Cc: evan@…
Patch Status:

Description

From devl@:

Maybe accounts should be on the left, with a vertical separator between it and General. Accounts really isn't a preference pane, but we're putting it in our preferences window for usability reasons.

Further discussion should be held here.

Change History (9)

comment:1 Changed 13 years ago by Peter Hosey

Seconded.

(Note: I'm a developer. Just because I just said “seconded” is not an invitation for every user who reads this to add their own vote. :)

comment:2 Changed 13 years ago by Chris Forsythe

Milestone: Adium X 1.1Needs dev review

Discussions like this have to take place on the dev milestone first.

comment:3 Changed 13 years ago by Colin Barrett

Milestone: Needs dev reviewAdium X 1.1

Not when they have been discussed on devl@ already.

comment:4 in reply to:  3 Changed 13 years ago by Chris Forsythe

Replying to cbarrett:

Not when they have been discussed on devl@ already.

So put them into this ticket.

comment:5 Changed 13 years ago by Colin Barrett

The relevant discussion is archived on devl@ here: http://adiumx.com/pipermail/adium-devl_adiumx.com/2007-January/001699.html (search for vertical).

Please read devl@. If not everyone who is involved in the project reads it regularly, then why is it even there (alternately, if they don't have time, maybe they should cut back their involvement in the project accordingly).

comment:6 Changed 13 years ago by Colin Barrett

Cc: evan@… added

Did some investigating on this.

AIPreferenceWindowController.m and PreferenceWindow.nib are the class and nib.

I'm not exactly sure how the actual tab view is being generated, with the icons and what not. Is that the NSTabView doing that? If that is in a different file, where is it?

Tagging Evan with tracmail so he can answer at his leisure

comment:7 in reply to:  5 Changed 13 years ago by Chris Forsythe

Replying to cbarrett:

The relevant discussion is archived on devl@ here: http://adiumx.com/pipermail/adium-devl_adiumx.com/2007-January/001699.html (search for vertical).

Please read devl@. If not everyone who is involved in the project reads it regularly, then why is it even there (alternately, if they don't have time, maybe they should cut back their involvement in the project accordingly).

1) I wouldn't call that "discussed". You mentioned it, Peter thought it was a good idea, nobody else chimed in.

2) People other than those subscribed to devl read trac tickets. Some of them may potentially become developers on the project. Minus the context of the "discussion" on devl, there's nothing here that shows how this was decided.

Replying to cbarrett:

Please read devl@. If not everyone who is involved in the project reads it regularly, then why is it even there (alternately, if they don't have time, maybe they should cut back their involvement in the project accordingly).

Trac is not an appropriate forum for comments like these.

comment:8 in reply to:  6 Changed 13 years ago by Evan Schoenberg

Replying to cbarrett:

Did some investigating on this.

AIPreferenceWindowController.m and PreferenceWindow.nib are the class and nib.

I'm not exactly sure how the actual tab view is being generated, with the icons and what not. Is that the NSTabView doing that? If that is in a different file, where is it?

Sorry for the delay; forgot to reply after I marked this read.

AIPreferenceWindowController specifies the ordering via an array... but the nib needs to be updated to match, I believe. Classic case of 'overcomplicated but works... so touch it lightly or rewrite it entirely :P'

comment:9 Changed 13 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [19325]) Reworked how the preferences window is generated and displayed.

  • We now use Matt Gemmell's SS_PrefsController (http://mattgemmell.com/ - updates to readme, etc. to follow) to dynamically generate the preferences window. There are some Adium-specific modifications to it, a fix for initial-selection, and the ability to include separators.
    • The preferences window can now allow resizing on a per-view basis if we want to do that. Refs #4380
    • The window will size both horizontally and vertically as necessary to display preferences. This should fix #6248.
    • AIAdvancedPreferencePane is now the superclass for advanced preferences.
    • The accounts pane is now first and separated from the rest by a separator. Fixes #6190.
  • Preferences nibs now have full control over their display. Any border between the view and the edge of the window is specified by that nib. This makes further modifications to the prefs much less finicky. Refs #1882.
  • The Advanced preferences UI now uses a source list. In the process, a minor drawing bug was corrected. Fixes #4708
  • Message history preferences are now in General. The advanced preferences for it have been removed from that pane. The behavior can be customized via the Customize button next to the checkbox. Fixes #6682.
  • General now utilizes bindings for most of its preferences.
Note: See TracTickets for help on using tickets.