Adium

Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#5558 closed defect (fixed)

OTR doesn't support XMPP

Reported by: am Owned by:
Milestone: Component: OTR
Version: Severity: major
Keywords: Cc:
Patch Status:

Description

OTR assumes that only one version of a message is sent. However, XMPP can send multiple versions -- either multiple bodies containing the same message in different languages (which isn't really relevant for Adium), (i)or both a plain text and an XHTML-based version. Right now, only the XHTML-version would be encrypted, in a non-compliant way (just a random blurp in an <html>-tag), which is even rather pointless when the plain text message is in the packet, too.

(note that I'm talking about the way the Smack-based plugin is implemented, I don't know about the libgaim one)

I marked the ticket critical, since people might think they're not revealing the text message when they actually do (without any warning). The least thing to do is to disable OTR for XMPP. Maybe we should implement JEP-0116 instead, so we can talk to non-Adium clients using encryption?

Change History (7)

comment:1 Changed 13 years ago by Chris Forsythe

Milestone: Adium X 1.1Needs feedback from users

Is this a problem with trunk?

comment:2 Changed 13 years ago by Evan Schoenberg

Owner: Evan Schoenberg deleted

comment:3 Changed 13 years ago by Eric Richie

Milestone: Needs feedback from usersWaiting on libotr

comment:4 Changed 13 years ago by Andreas Monitzer

Milestone: Waiting on libotrNeeds dev review

libgaim has to be able to set a different string for the formatted and the unformatted message part. According to Sean, it is possible, but we aren't using this yet.

However, there is no definition how multi-part messages should be handled by OTR, so this has to be looked into by somebody (talking to the gaim folks, too, since they have to do it the same way).

comment:5 Changed 12 years ago by thbohn

This ticket seems to be fixed in the current SVN trunk. At least I can see two encrypted messages in the XML console.

comment:6 Changed 12 years ago by Zachary West

Patch Status: None
pending: 0
Resolution: fixed
Status: newclosed

comment:7 Changed 12 years ago by Jordan

Milestone: Needs dev review
Note: See TracTickets for help on using tickets.