Adium

Opened 14 years ago

Closed 12 years ago

#5545 closed enhancement (fixed)

Metacontact Accounts UI sucks; scrap it

Reported by: boredzo Owned by: nobody
Milestone: Adium 1.3 Component: Adium UI
Version: Severity: normal
Keywords: contact buddy list blist info Cc:
Patch Status:

Description

While writing #5544, it occurred to me that there is no reason to have all those group pop-up menus in the Info window's Accounts tab for a metacontact, since a metacontact can only be in one group. The logical solution to this is to replace it with only one pop-up menu. Of course, from that point, one wonders why even have the pop-up menu; we can scrap the Accounts tab altogether for metacontacts, and let cmd-drag be the only way to move a metacontact from one group to another.

It's possible for one or more contacts of a metacontact to be in a different group from the metacontact itself, but I think that that shouldn't happen in the first place; we shouldn't have to have UI to work around that bug, at least after it's fixed.

Change History (6)

comment:1 Changed 14 years ago by Evan Schoenberg

So all contacts within a metacontact should be forced, serverside, to be in the same group?

Something else which is addressed by the UI which I think should be addressed somewhere is the per-account, per-contact (where services are matching) question of "is this contact on the serverside list?".

comment:2 in reply to:  1 ; Changed 14 years ago by Peter Hosey

Replying to evands:

So all contacts within a metacontact should be forced, serverside, to be in the same group?

Yup. The metacontact looks like it's in that group; I think it's strange for any component contact of it to be in some other group.

Something else which is addressed by the UI which I think should be addressed somewhere is the per-account, per-contact (where services are matching) question of "is this contact on the serverside list?".

Already addressed by [17780], the fix to #4897. Since that fix, every row in the table view corresponds to a contact on one account's list.

comment:3 in reply to:  2 Changed 14 years ago by Evan Schoenberg

Replying to boredzo:

Replying to evands:

So all contacts within a metacontact should be forced, serverside, to be in the same group?

Yup. The metacontact looks like it's in that group; I think it's strange for any component contact of it to be in some other group.

*nod* There's code in AIContactController which does this but is commented out, IIRC, or at least I wrote it and then removed it -- the unreliability of serverside moves at some point in the past made it better the more we could fake. I think our moves are fairly reliable now... though ICQ is still scary.

Something else which is addressed by the UI which I think should be addressed somewhere is the per-account, per-contact (where services are matching) question of "is this contact on the serverside list?".

Already addressed by [17780], the fix to #4897. Since that fix, every row in the table view corresponds to a contact on one account's list.

Ah, yes - I was unclear when I said the above, I should have said: The new UI addresses this problem; a future UI should take care to continue to do so :)

comment:4 Changed 14 years ago by David Smith

I'm not convinced our serverside moves are that safe yet... someone on irc had trouble with it recently. I could be misremembering though.

comment:5 Changed 14 years ago by Eric Richie

Milestone: Needs dev review

comment:6 Changed 12 years ago by Jordan

Milestone: Needs dev reviewAdium X 1.3
Patch Status: None
pending: 0
Resolution: fixed
Status: newclosed
Version: 1.0svn

This is now done (albeit broken at the moment) for 1.3.

Note: See TracTickets for help on using tickets.