Adium

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#5431 closed defect (fixed)

Messages in MSN are always aligned to the left for the other end

Reported by: ofri Owned by: ofri
Milestone: Adium X 1.1 Component: Service/MSN
Version: Severity: normal
Keywords: RTL MSN Cc:
Patch Status:

Description

IIRC, MSN uses a special bit to mark a message as LTR or RTL and if libgaim supports it we shall too.

Change History (12)

comment:1 Changed 13 years ago by ofri

Owner: changed from nobody to ofri
Status: newassigned

comment:2 Changed 13 years ago by Chris Forsythe

Milestone: Adium X 1.1Adium X 1.2

comment:3 Changed 13 years ago by Chris Forsythe

Milestone: Adium X 1.2Waiting on libgaim

Find out if libgaim supports this Ofri

comment:4 Changed 13 years ago by Evan Schoenberg

Once Gaim patch 1668681 is reviewed and accepted, this will be fixed, presumably.

comment:5 Changed 13 years ago by Eric Richie

Milestone: Waiting on libgaimWaiting on libpurple

comment:6 Changed 13 years ago by ofri

Patch Status: None

Unfortunately, this libpurple patch detects the writing direction (apparently) by looking for CSS properties in span tags, but AIHTMLDecoder uses a div tag with dir="rtl" attribute to mark RTL text. Which approach do you think is better?

comment:7 Changed 13 years ago by Evan Schoenberg

Milestone: Waiting on libpurpleAdium X 1.2

The patch mentioned above is integrated into libpurple 2.0.0. Based on your comment, ofri, we need to make some change to AIHTMLDecoder for the fix to be complete?

comment:8 Changed 13 years ago by ofri

Resolution: fixed
Status: assignedclosed

(In [20359]) When sending MSN messages, we now properly enclose them with span tags in order to support the MSN RTL flag. We still ignore this flag on incoming messages as we do a better job than MSN with figuring the direction of the message. Fixes #5431. BTW, I never worked with this code before so please let me know if I did something wrong.

comment:9 Changed 13 years ago by ofri

Keywords: RTL MSN added
pending: 0

Should this be merged to 1.1? Personally I don't care but seems it'll make a lot of people happy (although if they waited until now they can wait a bit more).

comment:10 Changed 13 years ago by Evan Schoenberg

Sure, go ahead and merge it :)

comment:11 Changed 13 years ago by ofri

(In [20363]) Merged [20359]: When sending MSN messages, we now properly enclose them with span tags in order to support the MSN RTL flag. Refs #5431.

comment:12 Changed 13 years ago by ofri

Milestone: Adium X 1.2Adium X 1.1
Note: See TracTickets for help on using tickets.