Adium

Opened 13 years ago

Closed 12 years ago

Last modified 11 years ago

#5159 closed patch (fixed)

Send file isn't a sheet, it's a new window

Reported by: roweiage@yahoo.com Owned by: cbarrett
Milestone: Adium 1.3 Component: Adium UI
Version: Severity: minor
Keywords: send file sheet window Cc: cbarret
Patch Status: Accepted

Description

When you click the "Send a file" toolbar button the open file dialogue opens a whole new window. Shouldn't create a pane attached to the chat window?

Attachments (1)

sendFileSheet.diff (3.2 KB) - added by Brian T. Kelley 13 years ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 13 years ago by bgannin

Milestone: Adium X 1.0Sometime after 1.0

Changed 13 years ago by Brian T. Kelley

Attachment: sendFileSheet.diff added

comment:2 Changed 13 years ago by Colin Barrett

field_haspatch: 01

The problem with this is that then you are window modal, and can't switch tabs.

comment:3 in reply to:  2 Changed 13 years ago by Brian T. Kelley

Replying to cbarrett:

The problem with this is that then you are window modal, and can't switch tabs.

In the current model, it is impossible to switch any tabs when the NSOpenPanel is displayed. With this, you can at least switch tabs in other windows.

comment:4 Changed 13 years ago by Colin Barrett

Hmm, I misread. we're talking about the "save file" window, not the "hey you got a file transfer request" window.

I'll give the patch further review soon.

comment:5 Changed 13 years ago by Colin Barrett

Owner: changed from nobody to Colin Barrett

comment:6 Changed 13 years ago by Colin Barrett

Ack, sorry to leave you hanging like this, Brian. I'll be getting this committed in the next couple of days, really!

comment:7 Changed 13 years ago by Colin Barrett

Brian, I need one more thing from you: your real name so you can be credited properly.

comment:8 Changed 13 years ago by Colin Barrett

Milestone: Good idea for "later"Needs feedback from users

comment:9 Changed 13 years ago by Colin Barrett

Cc: patches@… added

comment:10 in reply to:  8 Changed 13 years ago by Brian T. Kelley

Patch Status: None

Replying to cbarrett: Hello. My real name is Brian T. Kelley. Thanks!

comment:11 Changed 13 years ago by Jordan

Keywords: send file sheet window added
Milestone: Needs feedback from usersNeeds dev review
Patch Status: NoneNeeds Discussion
Version: 1.0b81.1svn

comment:12 Changed 12 years ago by Colin Barrett

Patch Status: Needs DiscussionOK; Needs Check-In
pending: 0

comment:13 Changed 12 years ago by Jordan

Milestone: Needs dev reviewAdium X 1.3

Since all seems well here... and 1.2 is in freeze, setting to 1.3

comment:14 Changed 12 years ago by Evan Schoenberg

Hey, Colin: You set this to OK; Needs Check-In back September. Going to act on it?

comment:15 Changed 12 years ago by Jordan

Cc: cbarret added; patches@… removed
Type: defectpatch

comment:16 Changed 12 years ago by Evan Schoenberg

Resolution: fixed
Status: newclosed

(In [23304]) Patch from brian6504 (2/16/2007, approved by cbarrett on 3/10/2007) to show the Send File dialogue as a sheet on an open chat if possible rather than a modal window. Fixes #5159. Thanks :)

comment:17 Changed 11 years ago by Robert

Patch Status: OK; Needs Check-InAccepted
Note: See TracTickets for help on using tickets.