Adium

Opened 15 years ago

Closed 10 years ago

Last modified 10 years ago

#49 closed defect (fixed)

Minimum size pref uses 9pt even when set smaller

Reported by: tick Owned by:
Milestone: Adium 1.4.1 Component: Adium Core
Version: Severity: normal
Keywords: Cc:
Patch Status: Accepted

Description

Minimum size pref is wonky in message window

from bugs.txt

Attachments (3)

Picture 8.png (95.4 KB) - added by mathuaerknedam 13 years ago.
time-size in Adium preview
Picture 9.png (61.8 KB) - added by mathuaerknedam 13 years ago.
time-size in SubEthaEdit preview
textsize.diff (687 bytes) - added by Tim Horton 10 years ago.
Patch to fix minimum text size being stuck to 9pt

Download all attachments as: .zip

Change History (31)

comment:1 Changed 15 years ago by adamiser

Resolution: worksforme
Status: newclosed

The minimum size preference works perfectly for me.

comment:2 Changed 15 years ago by David Smith

Milestone: Adium X 0.90

Removing milestone, since it's misleading on the roadmap.

comment:3 Changed 13 years ago by mathuaerknedam

This problem still exists as of 1.2svn 20596.

I'll upload two images. One is the messagestyle preview in Adium, and the other is the preview as rendered by SubEthaEdit using webkit (and I see the same thing in Safari). The time is styled in css as "font-size: .5em;", so it should look much smaller than it does in Adium. (No, I wouldn't really want the time that small, but given the bug, I have it set that way so that the time doesn't get bigger until the font is set > 18pt.)

As another test you can, in Adium, set the minimum font size to 1pt, and then set messagestyle font to 1pt. It won't be that small, but if you step up the point size you can see that Adium limits the minimum font size to 9pt.

Personally, I'd prefer that Adium not set an arbitrary limit, and just let the use set it at some absurdly low value. But if nothing else, the minimum font size dropdown should at least reflect the 9pt limit that exists.

Changed 13 years ago by mathuaerknedam

Attachment: Picture 8.png added

time-size in Adium preview

Changed 13 years ago by mathuaerknedam

Attachment: Picture 9.png added

time-size in SubEthaEdit preview

comment:4 Changed 13 years ago by David Smith

field_haspatch: 0
Patch Status: None
pending: 0
Resolution: worksforme
Status: closedreopened

comment:5 Changed 13 years ago by mathuaerknedam

Just in case it helps, Colloquy has the same problem. Minimum size goes to 1, but it won't let text display <9pt.

comment:6 Changed 13 years ago by Jordan

Milestone: Needs dev review
Version: 1.2svn

Perhaps this is a webkit issue?

comment:7 Changed 13 years ago by mathuaerknedam

Version: 1.2svn1.1.3

I don't think it's a webkit issue. Subethaedit will let me render type (using webkit) as small as I want.

comment:8 Changed 13 years ago by mathuaerknedam

Incidentally, this has been around since webkit was introduced. I first reported it on the sourceforge bugtracker.

comment:9 Changed 12 years ago by Carlos Morales

comment:10 Changed 12 years ago by Robert

Milestone: Needs dev reviewNeeds feedback from users
pending: 01

I'd imagine this is still around (?). Are you able to tell whether this has to do with webkit?

comment:11 Changed 12 years ago by mathuaerknedam

I don't think it's webkit. Using safari I can render text well below 9 pt. I can do the same in smultron and subethaedit, both of which use webkit. The odd thing is that colloquy behaves the same as Adium, but I'm told they share no code.

comment:12 Changed 12 years ago by Robert

Milestone: Needs feedback from usersAdium X 1.3.x

comment:1 Changed 12 years ago by trac-robot

pending: 10
Status: reopenedclosed

This ticket was closed automatically by the system. It was previously set to a Pending status and hasn't been updated within 14 days.

comment:2 Changed 12 years ago by Robert

Status: closedreopened

comment:3 Changed 11 years ago by Zachary West

Component: Core AdiumAdium Core

comment:4 Changed 10 years ago by Robert

Owner: anybody deleted

comment:17 Changed 10 years ago by Robert

Milestone: Adium 1.4.xAdium bugs

comment:18 Changed 10 years ago by mathuaerknedam

Summary: Minimum size pref is wonkyMinimum size pref uses 9pt even when set smaller

comment:19 Changed 10 years ago by Tim Horton

This seems to be due to WebKit having two different "minimum font size" settings - one which applies when specifying absolute sizes, and one for relative sizes. We're currently only setting the absolute size one, and a lot of themes use relative sizes; that minimum size is stuck at 9pt.

The attached patch fixes this.

Changed 10 years ago by Tim Horton

Attachment: textsize.diff added

Patch to fix minimum text size being stuck to 9pt

comment:20 Changed 10 years ago by Robert

Milestone: Adium bugsAdium 1.5
Patch Status: Needs Dev Review

Woot

comment:21 Changed 10 years ago by Zachary West

I don't believe this is the case.

"The font size for a web view is different than its logical font size. The minimum logical font size, for example, is the absolute minimum size at which the font will display onscreen. This is meant to be a functional boundary and not a style boundary. For example, the default value for a web view’s minimum logical font size is 9 points, because typical web content looks good on Mac OS X at font sizes of 9 point and above. The constraint assures that web content will always look good in a web view. If you know that your content will look good only at 12 points or above, you should change the minimum font size to 12 points and leave the minimum logical font size alone. This will assure that your content will never display at sizes less than 12 points, but the functional font size boundary of the web view will remain at 9 points to prevent any chance of displaying unnecessarily small text."

-setMinimumFontSize: "This method sets the minimum display font size for the web view, overriding all content-specified styles, including explicitly specified font sizes."

comment:22 Changed 10 years ago by Tim Horton

Right, that part is true, but it doesn't say anything about the *opposite* scenario: in our case, we want smaller text, and we're hitting the logical font size lower limit *first*, which is limiting us to a minimum of 9pt, no matter what.

Really, the bolded part is basically just saying that the overall minimum font size is just the absolute minimum, and can be used to *increase* the minimum, but not in the other direction.

Also by experimentation it's pretty clear this is the case.

comment:23 Changed 10 years ago by Zachary West

Patch Status: Needs Dev ReviewOK; Needs Check-In

Ah, I see. I was looking at it from the position of wanting to make the font size larger, not smaller. That sounds like a reasonable explanation and requirement for the change. (I didn't notice the summary change.)

comment:24 Changed 10 years ago by Frank Dowsett <wixardy@…>

Resolution: fixed
Status: newclosed

(In c334205de2c4) Patch from hortont424 to allow a minimum messagestyle font size of <9pt. Fixes #49

comment:25 Changed 10 years ago by Frank

Patch Status: OK; Needs Check-InAccepted

comment:26 Changed 10 years ago by Robert

Milestone: Adium 1.5Adium 1.4.1

1.4hg: 1ec859f7bb8c.

hortont424, even though you have contributed in the past as I remember you haven't been credited in Copyright.txt yet, have you? I'd like to change that. :)

comment:27 in reply to:  26 Changed 10 years ago by Tim Horton

Replying to Robby:

hortont424, even though you have contributed in the past as I remember you haven't been credited in Copyright.txt yet, have you? I'd like to change that. :)

Yep, I show up with a short patch now and then; that'd be awesome! I'm Tim Horton, by the way. Thanks!

comment:28 Changed 10 years ago by Robert Vehse

(In 41b67f82d8c2) Credit hortont424 in Copyright.txt. Refs #49. And some more additions to Changes.txt for 1.4.1.

Note: See TracTickets for help on using tickets.