Adium

Opened 14 years ago

Closed 11 years ago

#4702 closed defect (fixed)

Adium does not display pictures received from Gadu Gadu

Reported by: MarkS Owned by: nobody
Milestone: Adium 1.3.3 Component: Service/Gadu-Gadu
Version: Severity: normal
Keywords: Cc: patches@…
Patch Status:

Description

Gadu Gadu lets you send a picture (max size 20KB) to a user. It is displayed in the chat window. However, Adium does not display the picture. I am attaching a picture of how this is displayed in the original client. I have also verified/tested that this is an issue with the gaim client as well. So this ticket is opened up for tracking purposes.

This is a separate feature from file transfer.

Attachments (2)

GG_Picture_In_Chat(JPEG).JPG (78.4 KB) - added by Mark A. Specjal 14 years ago.
Screenshot how a picture (max size 20KB) is shown in original GG client
gg_image_support+basic_formatting.txt (15.3 KB) - added by Mark 13 years ago.

Download all attachments as: .zip

Change History (23)

Changed 14 years ago by Mark A. Specjal

Screenshot how a picture (max size 20KB) is shown in original GG client

comment:1 Changed 14 years ago by tymon@…

please..

comment:2 Changed 13 years ago by Mark

Appears that a patch has been submitted to Gaim to fix this issue. http://sourceforge.net/tracker/index.php?func=detail&aid=1575266&group_id=235&atid=300235

[ 1575266 ] Gadu Gadu images + txt format Patch for GG protocol. Adds new functionality. + Image sending/receiving + Basic text formatters (only receiving for now)

Changed 13 years ago by Mark

comment:3 Changed 13 years ago by David Smith

field_haspatch: 01
Milestone: Waiting on libgaimNeeds dev review

comment:4 Changed 13 years ago by Colin Barrett

Owner: changed from nobody to Evan Schoenberg

comment:5 Changed 13 years ago by Colin Barrett

Evan? Any progress on possibly landing at least part of that libgaim patch?

comment:6 Changed 13 years ago by Evan Schoenberg

I have no way (or really time) to test a Gadu-Gadu patch... I have no knowledge of the protocol or the prpl code. It would be inappropriate for me to commit the patch to libgaim without thorough testing and knowledge of what the changes might do. The Gadu-Gadu maintainer really needs to look at it or, failing that, I need someone(s) to test it and verify that it works as promised.

comment:7 Changed 13 years ago by Mark A. Specjal

I am willing to assist in testing the patch. I am still using the original gadu client. However, I agree with Evan that Bartosz, the Gaim gadu maintainer,should have looked at this. If you want to do a full set of quality tests I can probably test with Eric Ritchie. I also know Elliot has a gadu account if he is ok with assisting with testing I can work with either one.

comment:8 Changed 13 years ago by Colin Barrett

FWIW, I meant landing the GG patch in our libgaim tree, not necessarily pushing it upstream (that's obviously a Gaim issue).

If you guys want to test this, go ahead.

comment:9 Changed 13 years ago by Mark A. Specjal

This should only be committed to libgaim tree. I will let Evan decide how he would like to handle this(I am just offering to help out); otherwise, this issue will have to wait(I know Evan is a very busy person). It is a nice to have but it isn't critical.

comment:10 Changed 13 years ago by Evan Schoenberg

I prefer to maintain a policy of keeping the Libgaim.framework we're using in sync with either (1) HEAD of libgaim or (2) the most recent libgaim release. If the patch is good enough to ship with Adium, it should be committed upstream; if it isn't, we have no business using it :)

I'll email Bartosz this evening and find out if he plans to review the patch anytime soon, and we'll go from there.

comment:11 Changed 13 years ago by Colin Barrett

Cc: patches@… added

comment:12 Changed 13 years ago by Colin Barrett

Patch Status: Needs Discussion

I'm still not entirely happy with these flags, but setting to "needs discussion."

comment:13 Changed 13 years ago by Jordan

Milestone: Needs dev reviewWaiting on libpurple
Version: 1.0b41.0.3

According to #p220 the pidgin devs are fully aware of this ticket and patch. Since we're basically waiting on them to implement the patch, this is better off at waiting on libpurple until someone takes action on that codebase.

comment:14 Changed 12 years ago by Evan Schoenberg

pending: 0

I've added the patch from the sf.net tracker to #p220.

comment:15 Changed 12 years ago by Evan Schoenberg

Owner: changed from Evan Schoenberg to nobody

comment:16 Changed 12 years ago by Robert

Component: Other ProtocolGadu-Gadu

comment:17 Changed 12 years ago by Mark A. Specjal

Patch has been submitted to Pidgin: http://developer.pidgin.im/ticket/220#comment:14

comment:18 Changed 12 years ago by Carlos Morales

comment:19 Changed 12 years ago by Robert

Patch Status: Needs DiscussionNone
Summary: Adium does not display pictures recieved from Gadu GaduAdium does not display pictures received from Gadu Gadu

comment:20 Changed 11 years ago by Mark A. Specjal

Appears the issue was corrected in Pidgin/libpurple #p220.

comment:21 Changed 11 years ago by Robert

Milestone: Waiting on libpurpleAdium 1.3.3
Resolution: fixed
Status: newclosed

Thanks, Mark! :)
Hopefully, this will work in 1.3.3.

Note: See TracTickets for help on using tickets.