Adium

Opened 14 years ago

Closed 12 years ago

Last modified 11 years ago

#3647 closed enhancement (fixed)

Update default emoticon set for full MSN support

Reported by: www-adium@patrice.ch Owned by: jas8522
Milestone: Adium 1.3 Component: Xtras
Version: Severity: minor
Keywords: Cc: Marc Bejarano
Patch Status: Accepted

Description

Adium ships with a incomplete set of MSN emoticons. The full list (I hope) is documented by Microsoft at http://messenger.msn.com/Resource/Emoticons.aspx

Attachments (8)

Emoticon Sets.zip (803.7 KB) - added by Jordan 12 years ago.
Updated emoticon sets
Default.AdiumEmoticonset.zip (311.5 KB) - added by Jordan 12 years ago.
This should be all of them updated for the default set!
MSN.AdiumEmoticonset.2.zip (281.6 KB) - added by Jordan 12 years ago.
MSN.AdiumEmoticonset.zip (281.6 KB) - added by Jordan 12 years ago.
Default.AdiumEmoticonset.2.zip (154.2 KB) - added by Jordan 12 years ago.
Here's an updated default set that includes all the smileys and a few additional ones that people seem to use regularly.
eye-rolling-fix.diff (823 bytes) - added by Jordan 12 years ago.
This patch should fix the eye rolling icon not working for 8-)
MSN.AdiumEmoticonset.3.zip (323.7 KB) - added by Jordan 12 years ago.
Fixes animating icons not animating, and includes the eye-rolling fix I just attached. Also removes an icon that wasn't being used!
Emoticon sets DONE.zip (660.7 KB) - added by Bastian 12 years ago.
The latest emoticons i Did. Contains Default and MSN

Change History (46)

comment:1 Changed 13 years ago by Eric Richie

Component: MSNXtras
Milestone: Sometime after 1.0

comment:2 Changed 12 years ago by Carlos Morales

This could be fixed, making a xtra (like #851 or #1) the default msn emoticon pack in adium

comment:3 Changed 12 years ago by Jordan

Milestone: Good idea for "later"Adium X 1.3
Patch Status: None
pending: 0
Summary: MSN Emoticons set incompleteEmoticons set incomplete for MSN
Version: 0.891.2svn

This AdiuMSN Set is done Adium emoticon style but includes all the ones needed for full emoticon support for MSN. We should consider requesting permission for that for this release for better MSN support.

comment:4 Changed 12 years ago by Carlos Morales

The Adiumized MSN custom emotes set, is an updated version of AdiuMSN. If we want the most complete version available, I think this is the one.

comment:5 Changed 12 years ago by Jordan

priority: normallow
Severity: normaltrivial
Summary: Emoticons set incomplete for MSNUpdate default emoticon set for full MSN support
Type: defectenhancement
Version: 1.2svn

I think if we update to the Adiumized MSN set suggested by djmori we should remove some of them from the pack. It does indeed cover almost all of the ones built in to Windows Live Messenger, but it also has extras that can be rather annoying.

comment:6 Changed 12 years ago by Jordan

I have contacted the author to request that he make an adjusted set to be included in Adium or allow me to adjust them so we can take care of this for 1.3.

For reference, here is the list of MSN Emoticons that should be matched by these - no more, no less:

http://messenger.msn.com/Resource/Emoticons.aspx

comment:7 Changed 12 years ago by Marc Bejarano

cc me

comment:8 Changed 12 years ago by Carlos Morales

Cc: Marc Bejarano added

comment:9 Changed 12 years ago by Jordan

At the moment, I've got two sets almost ready to go:

  1. A set to replace the "Default" emoticon set. The objective here is to have support for all the Adium-style emoticons, plus all of the MSN set. In such a way, new users to Adium that are primarily using it for MSN will have all the common emoticons right off the bat.
  2. A replacement set for the MSN emoticon set. In this case all the smiley faces are identical to the Windows Live Messenger emoticons, except now it includes all of the additional ones, like airplane, xbox, etc.

The only thing left to do with them is clean up the edges so they look OK on dark backgrounds. I'm working with Bastian Olea to get this done in the next couple weeks.

comment:10 Changed 12 years ago by Jordan

Owner: changed from nobody to Jordan
Status: newassigned

comment:11 Changed 12 years ago by Carlos Morales

comment:12 Changed 12 years ago by Evan Schoenberg

How's it coming? :)

comment:13 Changed 12 years ago by Jordan

There are still some with some rough edges, but at least the majority of common emoticons (such as the smileys) are well cleaned up. I'm attaching them as they currently exist, which should be ok to merge for 1.3. I will still be working on cleaning the remaining ones up a bit, and will open another ticket when I get it all completed so they can be added to the nearest release at that time.

Changed 12 years ago by Jordan

Attachment: Emoticon Sets.zip added

Updated emoticon sets

Changed 12 years ago by Jordan

This should be all of them updated for the default set!

Changed 12 years ago by Jordan

Attachment: MSN.AdiumEmoticonset.2.zip added

Changed 12 years ago by Jordan

Attachment: MSN.AdiumEmoticonset.zip added

comment:14 Changed 12 years ago by Jordan

Dammit... forgot to check the box (you can ignore the one with the .2 on it)

comment:15 Changed 12 years ago by Evan Schoenberg

Woah. I'm not down with this giant default set. The vast majority of people who use emoticons use somewhere between 5 and 15 in my experience. I don't want to present an off-the-screen emoticon menu by default.

Furthermore, most of our users will be talking to people who won't have any clue what the textual versions of these mean. (li) means Lightning but (l) means Lightbulb? It's nonsense!

comment:16 Changed 12 years ago by Jordan

I had a feeling that would be the case - we can always post that set to the xtras site - the primary objective of this ticket from the start was to replace the MSN set - the default set would have just been a bonus for those coming from Windows Live Messenger or Messenger for Mac to have it enabled automatically.

Nonetheless, the only reason the sets are nearly unmanageably large is because of our list view - if that gets changed to a grid, then it's really rather simple for users to manage.

So if you're OK with the replacement MSN set (as that *is* the current set available in the mainline clients) then you can merge that and call this fixed.

comment:17 Changed 12 years ago by Jordan

Actually on second thought, there are still a few smileys that could be of benefit for the actual default set. Let me strip out the extras (such as those wrapped in parentheses) and leave it with just smileys, then I can merge the sets... I think that would be more reasonable. (So we can have emoticons like :| for example)

Changed 12 years ago by Jordan

Here's an updated default set that includes all the smileys and a few additional ones that people seem to use regularly.

comment:18 Changed 12 years ago by Evan Schoenberg

(In [23771]) out with the old MSN emoticon set. Refs #3647

comment:19 Changed 12 years ago by Evan Schoenberg

(In [23772]) In with the new, complete MSN emoticon set. Refs #3647

comment:20 Changed 12 years ago by Evan Schoenberg

Resolution: fixed
Status: assignedclosed

(In [23773]) Expanded default emoticon set from jas8522. Closes #3647

comment:21 Changed 12 years ago by Dimmuxx

:'( :) <:o) () still aren't animated like they should be.

comment:22 Changed 12 years ago by Dimmuxx

8-) is also wrong and there might be some more that's still not the normal msn ones so I report them when/if I find them.

Changed 12 years ago by Jordan

Attachment: eye-rolling-fix.diff added

This patch should fix the eye rolling icon not working for 8-)

Changed 12 years ago by Jordan

Attachment: MSN.AdiumEmoticonset.3.zip added

Fixes animating icons not animating, and includes the eye-rolling fix I just attached. Also removes an icon that wasn't being used!

comment:23 Changed 12 years ago by Jordan

Patch Status: NoneOK; Needs Check-In
Resolution: fixed
Status: closedreopened

comment:24 Changed 12 years ago by Evan Schoenberg

Which icon isn't being used?

comment:25 Changed 12 years ago by Jordan

There was a png and a gif of the icon... I just don't recall which one is was now. I think we were using the gif, which is right due to the animations, and making the png unnecessary.

comment:26 Changed 12 years ago by Evan Schoenberg

Resolution: fixed
Status: reopenedclosed

(In [23803]) Further fixes for MSN emoticons. Fixes #3647. Good work :)

comment:27 Changed 12 years ago by Bastian

Sorry for the time i took making this. I think these are almost done, but if any one have any improvement feel free to ask me :D Here are the files, please add them to the latest beta.

Changed 12 years ago by Bastian

Attachment: Emoticon sets DONE.zip added

The latest emoticons i Did. Contains Default and MSN

comment:28 Changed 12 years ago by Jordan

Resolution: fixed
Status: closedreopened

For the record, enkuturi is where they were coming from - I was just relaying them here. While I cleaned up a few of them, he re-did the ones that I did in a rush ;) so these should look better. I asked him to grab the ones from 1.3b3 and overwrite the new ones on top of that, so that the changes we made remain the same.

comment:29 Changed 12 years ago by Jordan

Resolution: fixed
Status: reopenedclosed

To clean up this ticket, I created a new one at #10182

I'll put this one down for good :P

comment:30 Changed 11 years ago by Robert

Patch Status: OK; Needs Check-InAccepted

comment:31 Changed 11 years ago by Simon

I'd like to add in a vote for the :| emoticon. Should I create a new ticket for that?

comment:32 Changed 11 years ago by Jordan

earthling: that one is already in the default set for me... I use it constantly! Are you sure it's not working with the default set selected in 1.3 or greater?

comment:33 Changed 11 years ago by Simon

Sorry -- that one is fine! The one I meant to request is the :T emoticon. I'm not sure if it's in the MSN set (Trillian has it), but it's another one I use constantly, so I wanted to at least cast a vote for it...

thanks for the response

comment:34 Changed 11 years ago by Jordan

As far as I can tell that is only implemented in Trillian - none of the primary messenger protocols. Therefore it's unlikely to be put in the default emoticon set, however you're more than welcome to create an emoticon set that uses it, or check out the sets on the Xtras site as one of them may already contain it.

comment:35 Changed 11 years ago by Jordan

Milestone: Adium X 1.3

comment:36 Changed 11 years ago by Jordan

Milestone: Adium X 1.3

Thought this was a new ticket for a second... back to 1.3 you go.

comment:37 Changed 11 years ago by Simon

Thanks for the suggestion. The problem with that is that the number of people who use a custom emoticon set will be very small; much smaller than the general Adium user base. Hope you will reconsider sometime in the future.

comment:38 Changed 11 years ago by Robert

So you'd like us to force an emoticon that is only used in Trillian on the broad userbase?

Note: See TracTickets for help on using tickets.