Adium

Opened 14 years ago

Closed 12 years ago

Last modified 12 years ago

#3540 closed defect (fixed)

URL Linking with domain not containing a period

Reported by: mykeolson@usa.net Owned by: earthmkii
Milestone: Adium 1.2 Component: Adium Core
Version: Severity: normal
Keywords: Cc:
Patch Status:

Description (last modified by Evan Schoenberg)

If you include a URL in an Adium chat that does not include a period in the domain (such as a hostname on an internal subnet that doesn't require the domain), the :/ part of http:// gets replaced with a undecided emoticon. This is similar to #3008 which affected all URL's but was only partially fixed.

For example, http://web/foo is a valid URL but Adium does not treat it as such.

Change History (18)

comment:1 Changed 14 years ago by David Smith

iirc this is fixed in 1.0

comment:2 Changed 14 years ago by David Smith

Resolution: worksforme
Status: newclosed

comment:3 Changed 13 years ago by cheesy

Resolution: worksforme
Status: closedreopened

This is [re-]broken in 1.0b18 (and some earlier versions); http://web/foo does not get 'linkified'.

In fact, any text that begins http:// will only be linkified if it ends in a known TLD. This is frustrating when I am sharing company internal URLs with co-workers.

Arguably, anything that starts http:// should be linkified since adium *knows* it's a link, whether it recognises the domain or not.

comment:4 Changed 13 years ago by Evan Schoenberg

Milestone: Adium X 1.0.1

comment:5 Changed 13 years ago by Evan Schoenberg

Description: modified (diff)

comment:6 Changed 13 years ago by Chris Forsythe

Milestone: Adium X 1.0.1Needs dev review

Not going to be fixed for 1.0.1, moving to dev review for a discussion on how to do this properly.

comment:7 Changed 12 years ago by Zachary West

Owner: changed from nobody to Stephen Holt
Patch Status: None
pending: 0
Status: reopenednew

comment:8 Changed 12 years ago by Stephen Holt

Component: NoneAdium Core
Status: newassigned

comment:9 Changed 12 years ago by Stephen Holt

Well, the lex code is matching everything starting with "http://" or "https://", but it's either not being honored by SHHyperlinkScanner, or getting unlinked somewhere else in the path to WebKit.

That was kinda a hackish way to do it, anyway, as only http/s URIs would get the link, not ssh, ftp, see, or whatever. And things like see://, ftp://, feed://, etc will not be linkified.

The expressions in that file could be re-organized anyway.

comment:10 Changed 12 years ago by Stephen Holt

How likely is it to run into a single-word domain, excepting localhost, in the wild?

Bonjour/ZeroConf and Active Directory all typically use .local for their pseudo-tld, which we catch.

I'm hesitant to match all <protocol>:<domain>/<path> URI's. In my mind, and since it's so incredibly non-standard, it's probably generally safer to copy/paste the link in the event you have something like: https://pizza.pie/peperoni. Or am I being overly paranoid?

comment:11 Changed 12 years ago by Zachary West

I know of a lot of different organizational non-period domains that I've run into. Way back in the day, my school's district website was accessible by a non-period domain (I honestly forget what it was, though). Perhaps they're a staple of beyond, but shrug.

Yeah, I'm not sure if it's worth matching such domains, but http://... is always gonna be a URL.

comment:12 in reply to:  11 Changed 12 years ago by Evan Schoenberg

Replying to zacw:

I know of a lot of different organizational non-period domains that I've run into.

Yup, at my current hospital, Grady Memorial, http://gradynet/ is the way to access the intraweb.

comment:13 Changed 12 years ago by David Smith

Likewise with http://ci, http://mrtg, and quite a few others for various services here at Jive.

comment:14 Changed 12 years ago by sholt

Resolution: fixed
Status: assignedclosed

(In [21220]) Adding rule for single word domain names, and retaining requirement for a valid TLD in more traditional URL's. Fixes #3540

comment:15 Changed 12 years ago by Robert

This needs a milestone, I think. Maybe it also has to be merged...

comment:16 Changed 12 years ago by Colin Barrett

Milestone: Needs dev reviewAdium X 1.1.4

comment:17 Changed 12 years ago by Colin Barrett

Merged in [21220]. I can't type.

comment:18 Changed 12 years ago by Colin Barrett

Milestone: Adium X 1.1.4Adium X 1.2

No, seriously I can't type. This wasn't merged, there was a conflict.

Note: See TracTickets for help on using tickets.