Adium

Opened 15 years ago

Closed 15 years ago

Last modified 10 years ago

#3058 closed defect (fixed)

<html> in xhtml-im Messages (Jabber)

Reported by: fh-adium@fholzhauer.de Owned by: evands
Milestone: Adium X 1.0 Component: Service/XMPP (Jabber)
Version: Severity: normal
Keywords: Cc:
Patch Status: Accepted

Description

The xhtml-Formatting of Jabber-Messages in Adium is broken (Output from ngrep):

<message from='user@…/Adium' to='otheruser@…' type='chat'><x xmlns='jabber:x:event'><composing/></x><body>yay</body><html xmlns='http://jabber.org/protocol/xhtml-im'><body xmlns='http://www.w3.org/1999/xhtml'><html>yay</html></body></html></message>

The inner <html> around the "yay" in the xhtml-im-part shouldnt be there, according to Jep 0071.

Attachments (1)

jabber-html-fix.diff (1.8 KB) - added by anonymous 15 years ago.
fixes #3058

Download all attachments as: .zip

Change History (9)

comment:1 Changed 15 years ago by Peter Hosey

Component: NoneJabber

what version of Adium?

comment:2 Changed 15 years ago by fh-adium@…

I have no idea, this appears from several users at mabber.com. One of them is using 0.87, but I doubt that all of them are using the same version.

comment:3 Changed 15 years ago by dchoby98

I can confirm this with Adium 0.89. I can consistently crash IMCom (http://dries.ulyssis.org/apt/packages/imcom/info.html is the best link I can find) by sending Jabber messages. The inner <html> is indeed bad.

comment:4 Changed 15 years ago by Colin Barrett

Do we, or does libgaim, handle this?

Changed 15 years ago by anonymous

Attachment: jabber-html-fix.diff added

fixes #3058

comment:5 Changed 15 years ago by anonymous

Here's the fix

comment:6 Changed 15 years ago by Evan Schoenberg

Milestone: Adium X 1.0
Owner: changed from nobody to Evan Schoenberg
Status: newassigned

comment:7 Changed 15 years ago by Evan Schoenberg

Resolution: fixed
Status: assignedclosed

The fix was committed in [15556].

comment:8 Changed 10 years ago by Robert

Patch Status: Accepted
Note: See TracTickets for help on using tickets.