Adium

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#2455 closed defect (fixed)

adium_input_add crashes when given invalid socket

Reported by: anonymous Owned by: evands
Milestone: Adium X 1.0 Component: Plugin
Version: Severity: normal
Keywords: Cc:
Patch Status:

Description

libgaim's gadu-gadu may pass fd=-1 to adium_input_add

this causes CFSocketCreateRunLoopSource to return NULL, which is then passed to CFRunLoopAddSource and causes crash.

Change History (4)

comment:1 Changed 15 years ago by Evan Schoenberg

Good catch!

comment:2 Changed 15 years ago by Evan Schoenberg

Owner: changed from nobody to Evan Schoenberg
Status: newassigned

comment:3 Changed 15 years ago by Evan Schoenberg

Resolution: fixed
Status: assignedclosed

(In [14480]) Verify we got a valid run loop source before trying to add it to the run loop. This fixes a crash if we're passed an invalid of fd of -1, which old (and perhaps current) gadu-gadu code did. Fixes #2455.

comment:4 Changed 15 years ago by David Smith

Milestone: Adium X 1.0
Note: See TracTickets for help on using tickets.