Adium

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#2300 closed defect (fixed)

Arrows in File Transfer Window require the AppleGothic font

Reported by: boredzo Owned by: boredzo
Milestone: Adium X 1.0 Component: Adium UI
Version: Severity: major
Keywords: ESFileTransfer FileTransfer file transfer AppleGothic Apple Gothic font crash starter Cc:
Patch Status:

Description (last modified by Evan Schoenberg)

Currently, the arrows require the AppleGothic font, which is installed with the system but may be uninstalled. Fix: draw the arrows ourselves.

Change History (18)

comment:1 Changed 14 years ago by Evan Schoenberg

Already fixed the crash in HEAD and adium-0.8 HEAD [we don't draw the arrow if Apple Gothic can't be found]... The font comes with the system... but if you want to rewrite the arrow drawing to be done ourselves, go for it :)

comment:2 Changed 14 years ago by Evan Schoenberg

Milestone: Adium X 0.87

comment:3 Changed 14 years ago by Evan Schoenberg

Summary: File transfers require the AppleGothic fontArrows in File Transfer Window require the AppleGothic font

comment:4 Changed 14 years ago by Peter Hosey

the user apparently deleted the font. not unreasonable; it isn't one of the core system fonts.

comment:5 Changed 14 years ago by Peter Hosey

Resolution: fixed
Status: newclosed

(In [14254]) We no longer use AppleGothic to draw the arrow badges on icons in the File Transfers window. Instead, we draw the arrow ourselves. Fixes #2300.

comment:6 Changed 14 years ago by Peter Hosey

(In [14255]) We no longer use AppleGothic to draw the arrow badges on icons in the File Transfers window. Instead, we draw the arrow ourselves. Fixes #2300.

comment:7 Changed 14 years ago by David Smith

Milestone: Adium X 0.87

comment:8 Changed 14 years ago by Evan Schoenberg

I think [14255] missed merging the arrowPathInSize:pointingDown: method.

comment:9 Changed 14 years ago by anonymous

Resolution: fixed
Status: closedreopened

comment:10 Changed 14 years ago by Chris Forsythe

Severity: normalblocker

This blocks on .87

comment:11 Changed 14 years ago by Peter Hosey

Resolution: fixed
Status: reopenedclosed

(In [14275]) Forgot to merge -arrowPathInSize:pointingDown:. Oops. Fixes #2300 (again).

comment:12 Changed 14 years ago by Evan Schoenberg

Resolution: fixed
Status: closedreopened

The arrow as drawn as of [14275] is too fat; the AppleGothic arrow makes a good template for how it should look.

comment:13 Changed 14 years ago by Evan Schoenberg

Milestone: Adium X 0.87Adium X 1.0

Moving this ticket to no longer require AppleGothic for the file transfer arrow overlay to 1.0 Milestone.

comment:14 Changed 14 years ago by Evan Schoenberg

Description: modified (diff)

comment:15 Changed 14 years ago by Evan Schoenberg

(In [14420]) Reverted ESFileTransfer in adium-0.8 to [14253]; we simply won't draw the arrow if AppleGothic isn't installed. We can fix this more 'properly' with an equally-attractive arrow for 1.0.

Refs #2300.

comment:16 Changed 14 years ago by David Smith

Keywords: starter added

This seems like it should be easy enough to fix. Just look at the code that was reverted and tweak until it looks right.

comment:17 Changed 14 years ago by Peter Hosey

Resolution: fixed
Status: reopenedclosed

(In [14837]) Got the arrow drawing correctly in both directions. Fixes #2300.

comment:18 Changed 14 years ago by Peter Hosey

(In [14851]) Moved arrow-path code to AIBezierPathAdditions, and genericised it by splitting it into (1) create an arrow path (2) flip it (3) resize it. Refs #2300. Added marks in AIBezierPathAdditions.

Note: See TracTickets for help on using tickets.