Adium

Opened 14 years ago

Closed 14 years ago

#2262 closed enhancement (fixed)

Text Cursors in the Text Fields are not pleasant in invert

Reported by: Owned by: nobody
Milestone: Adium X 1.0 Component: Adium UI
Version: Severity: normal
Keywords: Cc:
Patch Status:

Description

The color of the text cursor should be the inverted color of the background color of the text field. (It's practically impossible to see the text cursor when the bg color is black)

Attachments (2)

invertedColor.diff (2.8 KB) - added by Skyler 14 years ago.
TEH HOLY PATCH (the new one)
contrastingColor.diff (2.9 KB) - added by Skyler 14 years ago.
The newest one

Download all attachments as: .zip

Change History (12)

comment:1 Changed 14 years ago by Chris Forsythe

Milestone: Adium X 1.0

comment:2 Changed 14 years ago by Evan Schoenberg

Milestone: Adium X 1.0

This is technically an Apple bug... we can fix it in one of our custom subclasses most likely.

comment:3 Changed 14 years ago by Zachary West

Reporter: Skyler deleted
Summary: Text Cursors in the Text Fields are teh suckText Cursors in the Text Fields are not pleasant in invert

comment:4 Changed 14 years ago by Chris Forsythe

Milestone: Sometime after 1.0

comment:5 Changed 14 years ago by Skyler

This might work:

[self setInsertionPointColor:[NSColor colorWithCalibratedRed:1.0f - [backgroundColor redComponent] green:1.0f - [backgroundColor greenComponent] blue:1.0f - [backgroundColor blueComponent] alpha:1.0f]];

comment:6 Changed 14 years ago by David Smith

Resolution: fixed
Status: newclosed

(In [15375]) Patch from freakman. Fixes #2262

comment:7 Changed 14 years ago by David Smith

Milestone: Sometime after 1.0Adium X 1.0

comment:8 Changed 14 years ago by Peter Hosey

Resolution: fixed
Status: closedreopened

as kbotc mentions, this is no good when the background color is 50% gray. perhaps we should use the text color instead?

comment:9 Changed 14 years ago by Evan Schoenberg

There's an AIColorAdditions method which is probably right for this -- colorByAdjustingForBackground: or something like that is the name IIRC.

Changed 14 years ago by Skyler

Attachment: invertedColor.diff added

TEH HOLY PATCH (the new one)

Changed 14 years ago by Skyler

Attachment: contrastingColor.diff added

The newest one

comment:10 Changed 14 years ago by David Smith

Resolution: fixed
Status: reopenedclosed

Should be fixed now.

Note: See TracTickets for help on using tickets.