Adium

Opened 15 years ago

Closed 15 years ago

#2178 closed defect (fixed)

Plug-ins installed into the wrong directory on HFSX partitions.

Reported by: anonymous Owned by: tick
Milestone: Adium X 1.0 Component: Adium Core
Version: Severity: minor
Keywords: HFSX, case sensitive Cc:
Patch Status:

Description

If you are using a case sensitive filesystem such as HFSX installing plugins fails. The plugin is placed in "~/Application Support/Adium 2.0/Plugins/". But Adium does not detect plugins in this directory, Adium gets its plugins from "~/Application Support/Adium 2.0/PlugIns/" which is another directory on a case sensitive FS.

Change History (17)

comment:1 Changed 15 years ago by Zachary West

This is one of many, many problems associated with case-sensitiveness, including Xtras that do not work properly.

comment:2 Changed 15 years ago by Chris Forsythe

Milestone: Adium X 1.0

comment:3 Changed 15 years ago by Chris Forsythe

Hopefully resolved with #14008

comment:4 Changed 15 years ago by Chris Forsythe

Bah, [14008] was that.

comment:5 Changed 15 years ago by Chris Forsythe

Resolution: fixed
Status: newclosed

comment:6 Changed 15 years ago by anonymous

Resolution: fixed
Status: closedreopened

That didn't actually fix it. The directory should still be called "PlugIns" because this is where the Copy Files phase puts the internal plugins. The real problem is in AIAdium.m:

        destination = [ADIUM_APPLICATION_SUPPORT_DIRECTORY stringByAppendingPathComponent:@"Plugins"];

It should use @"PlugIns" there. Furthermore, the installation directory of the SQL Logger should be changed from "/Adium.app/Contents/Plugins/" to "/Adium.app/Contents/PlugIns/".

comment:7 Changed 15 years ago by Chris Forsythe

So right now everything is set to Plugins, and you want us to change it to PlugIns? I'd rather keep it as Plugins if that's how it all is right now. If not I'll change AIAdium.m to be Plugins in the morning.

comment:8 Changed 15 years ago by Chris Forsythe

Owner: changed from nobody to Chris Forsythe
Status: reopenednew

Bah, trac is being evil

comment:9 Changed 15 years ago by Chris Forsythe

Status: newassigned

comment:10 Changed 15 years ago by David Smith

unfortunately the name of the in-bundle plugins directory appears to be dictated to us by the system... we may have to rename the external one to PlugIns.

comment:11 Changed 15 years ago by dreamind@…

Well if Plugins should be used, then the remaining thing which needs to be fixed is Frameworks/Adium Framework/AIPathUtilities.m.

comment:12 Changed 15 years ago by Peter Hosey

dreamind: it shouldn't.

comment:13 Changed 15 years ago by Peter Hosey

Summary: Plug-ins installed ito the wrong directory on HFSX partitions.Plug-ins installed into the wrong directory on HFSX partitions.

Judge Lance Ito is not relevant to this ticket.

comment:14 Changed 15 years ago by Peter Hosey

I just tested with a case-sensitive (HFSX) disk image. Finder looks for 'PlugIns', so that is what the internal plug-ins folder must be named. we're free to name the external folders whatever we want, though.

comment:15 Changed 15 years ago by Evan Schoenberg

Resolution: fixed
Status: assignedclosed

This is fixed in 1.0svn.

comment:16 Changed 15 years ago by anonymous

Resolution: fixed
Status: closedreopened

This is still an issue. I don't know what changed or when (well I know that it happened approximately a month ago in SVN). I do know how to fix it:... all that has to be done is to change the line in AICorPluginLoader.m

#define DIRECTORY_INTERNAL_PLUGINS [@"Contents" stringByAppendingPathComponent:@"Plugins"]

to

#define DIRECTORY_INTERNAL_PLUGINS [@"Contents" stringByAppendingPathComponent:@"PlugIns"]

comment:17 Changed 15 years ago by Evan Schoenberg

Resolution: fixed
Status: reopenedclosed

(In [15532]) s/Plugins/PlugIns so our directory names are case consistent, fixing problems on case sensitive file systems. Fixes #2178

Note: See TracTickets for help on using tickets.