Adium

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#15867 closed enhancement (fixed)

Add support for OS X 10.8 notification center

Reported by: paulmillr Owned by: sphynx
Milestone: Adium 1.5.4 Component: Events
Version: 1.5hg Severity: major
Keywords: 10.8, mountain lion, notification center, notifications Cc:
Patch Status:

Description

OS X 10.8 Mountain Lion introduces support of notifications.

It has iOS-like notification center http://www.apple.com/macosx/mountain-lion/features.html#notifications.

It will be nice if adium had supported it.

Change History (47)

comment:1 follow-up: Changed 5 years ago by wixardy

  • Resolution set to wontfix
  • Status changed from new to closed

To use it we'd need to be in the app store (#14914).

comment:2 follow-up: Changed 5 years ago by wixardy

  • Resolution wontfix deleted
  • Status changed from closed to new

Looks like I was wrong.

comment:3 Changed 5 years ago by MSch

Any updates on this? Mountain Lion will be released pretty soon and Notification Center support is IMO a must.

comment:4 Changed 5 years ago by csmcdem

I've been using Hiss (http://collect3.com.au/hiss/), but would love native notification center support

comment:5 follow-ups: Changed 5 years ago by vyke

Why isn't this ticket taken seriously? What is the timeline for notification center support in Adium?

comment:6 in reply to: ↑ 5 Changed 5 years ago by csmcdem

Replying to vyke:

Why isn't this ticket taken seriously? What is the timeline for notification center support in Adium?

They're waiting for Growl to support it. I fixed it and made a pull request here
https://bitbucket.org/adium/adium/pull-request/1/108-mountain-lion-notification-center

comment:7 in reply to: ↑ 5 ; follow-up: Changed 5 years ago by sphynx

Replying to vyke:

Why isn't this ticket taken seriously? What is the timeline for notification center support in Adium?

Yeah! You guys had 7 hours to do it! Why do I not have it yet?! That's ridiculous!

But seriously, I don't agree with Zac's comment, or the pull request. There probably are a number of people who use Growl for some of their notifications (maybe with Prowl), but want to use NC for some others.

I think the best approach would be to add a new Action to the Event Preferences to "Display a Notification Center Notification" (or something like that).

comment:8 in reply to: ↑ 7 ; follow-up: Changed 5 years ago by csmcdem

Replying to sphynx:

Replying to vyke:

Why isn't this ticket taken seriously? What is the timeline for notification center support in Adium?

Yeah! You guys had 7 hours to do it! Why do I not have it yet?! That's ridiculous!

But seriously, I don't agree with Zac's comment, or the pull request. There probably are a number of people who use Growl for some of their notifications (maybe with Prowl), but want to use NC for some others.

I think the best approach would be to add a new Action to the Event Preferences to "Display a Notification Center Notification" (or something like that).

That's easy enough with my pull request. As of now it has a growl fallback, and all the growl code is still there

comment:9 Changed 5 years ago by vyke

Mountain Lion has been out for a few months for developers ... the commercial version just hit the store today. The point of giving developers a head start is so they have fair time to integrate their apps with relevant features before the OS launches. Don't get me wrong, I love adium and the work that goes into the great product, but many feel notifications is an integral part of the product and now the OS gives developers (adium) a direct integration method.

comment:10 in reply to: ↑ 8 ; follow-up: Changed 5 years ago by MSch

Replying to csmcdem:

Replying to sphynx:

Replying to vyke:
I think the best approach would be to add a new Action to the Event Preferences to "Display a Notification Center Notification" (or something like that).

That's easy enough with my pull request. As of now it has a growl fallback, and all the growl code is still there

I completely agree. It's ridiculous to wait for an update to Growl (isn't that closed source nowadays?) when ML has now already been released and there is code that simply works with NC on 10.8 and Growl on <10.8

Can someone please merge this PR and push out a new beta release?

Last edited 5 years ago by MSch (previous) (diff)

comment:11 in reply to: ↑ 10 ; follow-up: Changed 5 years ago by csmcdem

Replying to MSch:

Replying to csmcdem:

Replying to sphynx:

Replying to vyke:
I think the best approach would be to add a new Action to the Event Preferences to "Display a Notification Center Notification" (or something like that).

That's easy enough with my pull request. As of now it has a growl fallback, and all the growl code is still there

I completely agree. It's ridiculous to wait for an update to Growl (isn't that closed source nowadays?) when ML has now already been released and there is code that simply works with NC on 10.8 and Growl on 10.8

Can someone please merge this PR and push out a new beta release?

http://dl.dropbox.com/u/455197/Adium.zip

comment:12 in reply to: ↑ 11 ; follow-up: Changed 5 years ago by MSch

Replying to csmcdem:

Replying to MSch:

Can someone please merge this PR and push out a new beta release?

http://dl.dropbox.com/u/455197/Adium.zip

Thanks. Makes me happy that I don't have to learn how to use hg and build Adium myself.

Now is there a way we can get that version pushed to regular Adium users?

It's IMO a horrible experience for users if they install Adium on their new 10.8 install and there's no NC support.

comment:13 in reply to: ↑ 12 Changed 5 years ago by csmcdem

Replying to MSch:

Replying to csmcdem:

Replying to MSch:

Can someone please merge this PR and push out a new beta release?

http://dl.dropbox.com/u/455197/Adium.zip

Thanks. Makes me happy that I don't have to learn how to use hg and build Adium myself.

Now is there a way we can get that version pushed to regular Adium users?

It's IMO a horrible experience for users if they install Adium on their new 10.8 install and there's no NC support.

That's up to the adium devs. I have no control over it.

comment:14 Changed 5 years ago by Beriechil

Are they still waiting for Growl? I would prefer not having to buy the new Growl just to use Notification Center with Adium.

comment:15 Changed 5 years ago by Robby

I don't think the Adium Team has reached a decision, yet. But it's not about the Growl app but the Growl SDK which Adium ships with.

comment:16 Changed 5 years ago by Beriechil

Ohh, so with the new SDK, users won't have to have Growl installed if they're on Mountain Lion? In that case, sorry for confusion :)

comment:17 Changed 5 years ago by Robby

Correct.

Actually, as of right now Adium is able to post Growl notifications without the app installed. See http://adium.im/help/pgs/AdvancedFeatures-GrowlSupport.html for more info.

comment:18 Changed 5 years ago by dcentity2000

I'd certainly be more inclined to donate to Adium if it supported Notification Center out of the box :)

comment:19 follow-up: Changed 4 years ago by lad1337

i would be even inclined to buy adium ! .. like with real money !

and thanks csmcdem the version works great for me :)

the issue i have with using the growl passthru is that all notification will be grouped into a growl group and not into its appropriate program
its also the reason i didnt like hiss

until then i will use the version with this patch

comment:20 in reply to: ↑ 19 Changed 4 years ago by csmcdem

Replying to lad1337:

i would be even inclined to buy adium ! .. like with real money !

and thanks csmcdem the version works great for me :)

the issue i have with using the growl passthru is that all notification will be grouped into a growl group and not into its appropriate program
its also the reason i didnt like hiss

until then i will use the version with this patch

no problem, glad other people could make use of it.
hopefully the growl update won't group them, because it bothers me too :(.
if it does, maybe the adium devs will reconsider the pull request. until we know more about the growl update, i support their decision

Last edited 4 years ago by csmcdem (previous) (diff)

comment:21 Changed 4 years ago by ss7

I'd like to add my thanks to csmcdem for producing the version that supports Notification Center. Now if only your build were code-signed... ;-)

The fact that the release version of Adium does not yet support Notification Center is slightly vexing, but having read the comments against the pull request, and the plans for the Growl SDK I do understand the decision to hold off. It's just a shame the new Growl 2.0 SDK that supports sending out to the Notification Center isn't out yet. Given the stability problems that Growl have had with their app code since going commercial let's hope that isn't affecting their SDK and it will leave beta soon.

comment:22 Changed 4 years ago by pininfrna

I'd just like to add my two cents to this topic. Growl's done. Over. Notification center killed it. Why not just drop Growl and integrate directly with Notification Center, as opposed to waiting until Growl 2.0 is out? That just adds a new abstraction layer. Adium is already getting bloated, and its selling point has traditionally been its leanness and meanness. I don't want Adium to suffer the same fate as growl.

comment:23 Changed 4 years ago by GRMrGecko

Wow... Haters...

Let me state this... Growl started out in Adium. The Adium team made it and decided to split it up into it's own project.

Growl is open source and has been. There is however a delay in the release of source code now that the main developers decided to charge for it.

Growl 2 is in beta now, https://growl.posterous.com/growl-2-and-hardwaregrowler-2-both-in-beta.

Dropping growl, in my opinion, is not an option for the Adium team. Supporting Notification Center in addition is something I would love to see. If they chose to do so by waiting for version 2 of growl, more power to them.

Do not complain, do not say how stupid the developers of Adium are for not supporting it. Just be happy that Adium exists and it's open source for you to fix what you hate about it. Including implementing Notification Center for yourself.

comment:24 Changed 4 years ago by pininfrna

That's the point... Notification Center has been implemented. But it's not finding its way into builds. We're trying to be constructive here. Nobody called the developers stupid. It's hard for me not to interpret these events as an attempt to nurse Growl along, when the writing is already on the wall.

comment:25 follow-up: Changed 4 years ago by Robby

Nobody can stop you from interpreting things the way you like. :) The matter is still being discussed though.

But you seem to forget that Adium supports versions of OS X older than 10.8 so dropping Growl entirely wouldn't go down well with a lot of people. And while "leanness and meanness" is definitely desirable, Adium is also known for its customisability.

comment:26 in reply to: ↑ 25 Changed 4 years ago by lad1337

Replying to Robby:

Nobody can stop you from interpreting things the way you like. :) The matter is still being discussed though.

But you seem to forget that Adium supports versions of OS X older than 10.8 so dropping Growl entirely wouldn't go down well with a lot of people. And while "leanness and meanness" is definitely desirable, Adium is also known for its customisability.

i agree and the customizability is one major reason for adium !
and drooping growl is also not an option in my opinion

i have been using the custom version(with 10.8 notifications) now for a few days and it is working great no issues with adium
but the 10.8 notifications aren't as user friendly as growl notifications ... no custom notification icon, only app icon and no way of premature dismissing of notifications while the they are displayed and only one notification at a time ... of course this is a global problem and not a adium problem ... just something i noticed

comment:27 follow-up: Changed 4 years ago by pininfrna

I'm of the mind that an IM application should not be 64 MB and include 20 embedded frameworks. Notification Center provides a valuable opportunity to break free from some legacy stuff and trim down the app, but the developers don't seem to be interested. Recall that Growl was born out of frustration over the fact that nothing similar existed in the OS. Now it does. Notification Center might not be 100% of the way there yet, but it is the future and it's on every new Mac. Cleaning up and trimming is not as gratifying as adding features, but it is worthwhile and users appreciate it (i.e. compare the reception of Snow Leopard with that of Leopard.) I speak as an Adium user for ~10 years.

comment:28 Changed 4 years ago by Robby

  • Milestone set to Adium 1.5.4

comment:29 in reply to: ↑ 1 ; follow-up: Changed 4 years ago by supermattzor

Replying to wixardy:

To use it we'd need to be in the app store (#14914).

That's actually not true as far as I can tell. There's an API for Notification Center. For example, Chrome can use those notifications and it's not in the MAS.

Edit: I just realized that the post directly below the one that I replied to is acknowledging this. I retract my attempt at looking smart.

Last edited 4 years ago by supermattzor (previous) (diff)

comment:30 in reply to: ↑ 2 Changed 4 years ago by Robby

Replying to wixardy:

Looks like I was wrong.

comment:31 in reply to: ↑ 29 Changed 4 years ago by GRMrGecko

Replying to supermattzor:

Edit: I just realized that the post directly below the one that I replied to is acknowledging this. I retract my attempt at looking smart.

Why retract when you really are smart? Just a thought:P

comment:32 in reply to: ↑ 27 ; follow-up: Changed 4 years ago by earthmkii

Replying to pininfrna:

I'm of the mind that an IM application should not be 64 MB and include 20 embedded frameworks. Notification Center provides a valuable opportunity to break free from some legacy stuff and trim down the app, but the developers don't seem to be interested. Recall that Growl was born out of frustration over the fact that nothing similar existed in the OS. Now it does. Notification Center might not be 100% of the way there yet, but it is the future and it's on every new Mac. Cleaning up and trimming is not as gratifying as adding features, but it is worthwhile and users appreciate it (i.e. compare the reception of Snow Leopard with that of Leopard.) I speak as an Adium user for ~10 years.

In concept, I agree with you, a smaller Adium bundle would be wonderful, but as a point of fact, Growl.framework is only 664KiB, or roughly 0.94% of the app bundle's size for the latest release version. A far greater proportion (roughly 40%) exists in the Resources folder - most of which is localization. Dropping localizations, however, is just not going to happen. Nor will dropping libpurple and it's support libraries, which make up roughly another 30% of the bundle's girth, as they're required for Adium's core functionality.

I get where you're coming from, but this point doesn't especially bolster your case ;)

comment:33 Changed 4 years ago by paulmillr

pretty tired of mail notifications on this ticket (i’m creator). any way to unsubscribe?

comment:34 in reply to: ↑ 32 ; follow-ups: Changed 4 years ago by pininfrna

Replying to earthmkii:

In concept, I agree with you, a smaller Adium bundle would be wonderful, but as a point of fact, Growl.framework is only 664KiB, or roughly 0.94% of the app bundle's size for the latest release version. A far greater proportion (roughly 40%) exists in the Resources folder - most of which is localization. Dropping localizations, however, is just not going to happen. Nor will dropping libpurple and it's support libraries, which make up roughly another 30% of the bundle's girth, as they're required for Adium's core functionality.

I know that removing Growl alone isn't going to make the bundle that much smaller, but that doesn't mean it's not worthwhile. When Apple did Snow Leopard there was no single optimization that yielded a huge savings in space- it was literally thousands of little things. Growl has been obsoleted by OS X 10.8. The idea of "upgrading" to Growl 2.0 is especially distasteful to me, because there would be two notification systems, with one bridging to the other. This is not clean, this is not forward-thinking, this is not modern. Yes, some users who have grown accustomed to Growl will gripe if it's removed, just as people griped about the death of the floppy disk, DVD drive in MacBooks, .Mac to iCloud, etc. Growl at this point is so obviously legacy that removing it just seems like a no-brainer to me. Or at least put a death warrant out on it, and wait until more people are on 10.8 before killing it. Embracing Growl 2 as the future for Adium is a misguided pursuit.

comment:35 in reply to: ↑ 34 Changed 4 years ago by GRMrGecko

Replying to pininfrna:

I know that removing Growl alone isn't going to make the bundle that much smaller, but that doesn't mean it's not worthwhile. When Apple did Snow Leopard there was no single optimization that yielded a huge savings in space- it was literally thousands of little things. Growl has been obsoleted by OS X 10.8. The idea of "upgrading" to Growl 2.0 is especially distasteful to me, because there would be two notification systems, with one bridging to the other. This is not clean, this is not forward-thinking, this is not modern. Yes, some users who have grown accustomed to Growl will gripe if it's removed, just as people griped about the death of the floppy disk, DVD drive in MacBooks, .Mac to iCloud, etc. Growl at this point is so obviously legacy that removing it just seems like a no-brainer to me. Or at least put a death warrant out on it, and wait until more people are on 10.8 before killing it. Embracing Growl 2 as the future for Adium is a misguided pursuit.

Growl is still very useful. It works better than Notification Center in some ways, and worse in other ways. All growl 2.0 will do, as far as I think, will allow people to set a preference in the app or on growl it self to send notifications to Notification Center. Example, you use the same API you have built into your app, but add little code to add a preference to change from Growl to Notification Center.

comment:36 in reply to: ↑ 34 Changed 4 years ago by earthmkii

Replying to pininfrna:

Apologies, but I don't want to get into hair splitting about what's effective to remove and what isn't. Just wanted to point out that there are bigger wins from lower hanging fruit.

But, 2 things:

Growl has been obsoleted by OS X 10.8.

Not really. Growl allows attaching auxiliary actions to notifications. Meaning, a given action can show an alert and trigger an AppleScript to run, or fire a remote notification via a iPhone push relay, etc. This is a significant amount of value for Growl users, I would hesitate to remove this as it holds real additional value to its users.

The idea of "upgrading" to Growl 2.0 is especially distasteful to me, because there would be two notification systems, with one bridging to the other.

Let's examine how the Growl team has outlined how the Growl.framework, Growl.app and Notification Center interact.

Doing this first requires an examination of the various cases in the growl notification system as it exists today:

  • Pre-NC support:
    1. Growl.app is installed
      • Notification tickets are sent to the Growl.app which displays them and performs actions and displays notifications as configured by the user
    2. Growl.app is not installed
      • Growl's Mist system displays default notifications based on the app's configuration.

...and now how they're changing with NC support

  • Post-NC support:
    1. Growl.app is installed, and the user has configured growl to NOT use NC
      • Notifications work as before. Notification tickets are sent to the Growl.app which displays them and performs actions and displays notifications as configured by the user
    2. Growl.app is installed, and the user has configured Growl.app to use NC
      • Growl.framework detects this state from within the app and notifications are sent directly to NC from the app's process. Additionally, notification tickets are sent to growl which performs any associated actions. Growl.app displays nothing.
    3. Growl.app is not installed
      • Growl.framework detects this state from within the app and notifications are sent directly to NC from the app's process. Nothing else is done.

In both cases 2 and 3 above, the usage of the Notification Center API is from the app itself. This makes growl.framework more of an adaptive abstraction layer, and less "one bridging to the other." All NC notifications come from Adium proper, not growl on behalf of Adium.

Given this, I see no technical reason not to continue with a plan to use Growl 2.0. Existing functionality is preserved, and new functionality is added in a coherant way.

comment:37 Changed 4 years ago by pininfrna

Thanks for clarifying. The Growl 2.0 integration is not as distasteful as I feared, as it gets bypassed if the Growl app is not installed. I still argue against Growl, simply because the majority of its role in Adium is being replaced by Notification Center. The edge-case stuff that Growl handles (i.e. AppleScript invocation) could be implemented in Adium itself, and would be more elegant (I never liked Growl in case you can't tell.) But as long as I know that Adium is talking directly to NC, it's not as bothersome to me.

Big-picture-wise, I do think it's getting to be time for a Snow Adium... but that is a topic for a different trac.

comment:38 Changed 4 years ago by Thijs Alkemade <thijsalkemade@…>

  • Resolution set to fixed
  • Status changed from new to closed

(In 47e32218485b) Updated the Growl SDK to 2.0.

Fixes #15867.

comment:39 Changed 4 years ago by Robby

  • Resolution fixed deleted
  • Status changed from closed to new

comment:40 Changed 4 years ago by Robby

  • Owner set to sphynx

comment:41 Changed 4 years ago by Robby

  • Resolution set to fixed
  • Status changed from new to closed

comment:42 Changed 4 years ago by Robby

  • Severity changed from normal to major

comment:43 Changed 4 years ago by arobinson

Is the "fix" support for Growl 2.0? If so that is not very helpful for launching the app, and I would prefer this to be re-opened with a fix to use the notification center APIs directly when available.

For example, if you have a notification in growl 2.0 and you have it set to use notification center, and then you click on the notification, growl will not bring adium to the foreground / active window. When I get the notification I would like to be able to click it to open the chat window.

This is also an issue in the fact that growl can only have one notification center configuration instead of having one per application (like the ability to keep the adium notifications up and not auto-dismiss)

comment:44 Changed 4 years ago by Beriechil

Don't worry, it works as it should - the Growl 2.0 framework uses Notification Center in a way that displays notifications as Adium notifications, complete with the right icon and in an Adium section, and they activate the Adium conversation window if you click on them. I know because I've been using Adium 1.5.4 beta for a while. Though as far as I know, it wouldn't work correctly if you're also using something like Hiss, because then your local Growl installation will intercept the notifications and not let them go to Notification Center correctly.

comment:45 Changed 4 years ago by Robby

To me, arobinson's comment read as if I he/she actually tried the beta. Did you, arobinson? If not, please do and let us know of your experiences with it.

Last edited 4 years ago by Robby (previous) (diff)

comment:46 Changed 4 years ago by arobinson

I have adium 1.5.3 and growl 2.0. Clicking on the notification from growl in the ML notification center does nothing. I'll try the beta

comment:47 Changed 4 years ago by arobinson

The beta 3 works as expected, thanks

Note: See TracTickets for help on using tickets.