Adium

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#15705 closed defect (fixed)

Facebook login fails for account with login approvals enabled

Reported by: alexr Owned by:
Milestone: Adium 1.5.3 Component: Service/Facebook
Version: Severity: normal
Keywords: Cc:
Patch Status: Rejected

Description

Summary

Adding a Facebook account with login approvals (which requires entry of a security code sent by SMS to the user) doesn't succeed, and instead repeatedly asks for the code.

Steps to reproduce

  1. Prerequisite: Facebook account with login approvals set up and enabled
  2. Add a new Facebook account in Adium's preferences
  3. Enter email address and password
  4. (Receive security code by SMS)
  5. Enter security code, click 'Submit Code'

Expected results

Security code is accepted, the device is (optionally) named in the next step, and the account would be added and logged in.

Actual results

Repeatedly prompted for the security code, which triggers a new SMS to be sent each time.

Regression

Problem occurs with Adium 1.4.4 on OS X 10.7.2

Notes

Debug log attached

Attachments (2)

facebookaccount.log.zip (2.8 KB) - added by alexr 9 years ago.
Debug log output when attempting to add account
adiumpatch (1.6 KB) - added by Yuliy Pisetsky 8 years ago.
Fix for Facebook login in Login Approvals case

Download all attachments as: .zip

Change History (13)

Changed 9 years ago by alexr

Attachment: facebookaccount.log.zip added

Debug log output when attempting to add account

comment:1 Changed 9 years ago by Frank

Ticket #15907 has been marked as a duplicate of this ticket.

comment:2 Changed 8 years ago by liz4cps

I'm having a similar problem except I am not getting the SMS with a code or seeing any way to enter a code. It simply asks me to name the device over and over. It also flags a notification in Facebook on Safari (or Firefox). I can follow the instructions there and tell Facebook that it's ok, but it still keeps asking about the device.

Workaround is to simply turn off the login notifications. I don't like that but I guess it's worth it to have Facebook chat in Adium.

comment:3 Changed 8 years ago by liz4cps

PS I reported this problem to Facebook, for what it's worth.

comment:4 Changed 8 years ago by Tony

Having the same issue as liz4cps. Constant prompting to name device, but won't let you move beyond that screen

comment:5 Changed 8 years ago by Tim Shubitz

Just enabled login approvals via my Facebook account and tried setting up Adium 1.5 against it. No go.

Constantly asked for SMS code.

  • tim

Changed 8 years ago by Yuliy Pisetsky

Attachment: adiumpatch added

Fix for Facebook login in Login Approvals case

comment:6 Changed 8 years ago by mathuaerknedam

Patch Status: Needs Dev Review

comment:7 Changed 8 years ago by Yuliy Pisetsky

Ping. Is there anything else I can do to help make sure this fix gets in to the next release?

comment:8 Changed 8 years ago by Robert

cc

comment:9 Changed 8 years ago by Thijs Alkemade <thijsalkemade@…>

Resolution: fixed
Status: newclosed

(In c2721a058c9b) Inspired by the patch from ypisetsky, ensure AIFacebookXMPPOAuthWebViewWindowController doesn't keep multiple cookies around with the same name, by using a dictionary instead of a set for the cookies.

Fixes #15705

comment:10 Changed 8 years ago by Robert

Milestone: Adium 1.5.3
Patch Status: Needs Dev ReviewRejected

comment:11 Changed 8 years ago by Thijs Alkemade <thijsalkemade@…>

(In c9f0ada1220d) Changelog the previous change, fix the enumerating of all cookies (thanks ypisetsky).

Refs #15705

Note: See TracTickets for help on using tickets.