Adium

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#15583 closed defect (fixed)

Unable to connect to Facebook Chat

Reported by: Robby Owned by:
Milestone: Adium 1.4.4 Component: Service/Facebook
Version: Severity: major
Keywords: Cc:
Patch Status:

Description

Summary

Attaching debug log

Attachments (1)

1.5b2 Facebook connection issue.txt (274.7 KB) - added by Robert 8 years ago.
Debug log

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by Robert

Debug log

comment:1 Changed 8 years ago by Robert

Milestone: Adium 1.5
Severity: normalmajor

comment:2 Changed 8 years ago by Thijs Alkemade

My guess: since 982e401f8d00 we're authenticating with an access_token instead of a session_key. However, if the account already existed, we don't request a new access_token, but use the session_key from the keychain and sent that as if it were an access_token.

Does removing and adding the account again fix it?

comment:3 Changed 8 years ago by Thijs Alkemade

Adding to this, it seems we never store the oAuthToken in AIFacebookXMPPAccount.m, which means we have to ask users to login again. =/

comment:4 in reply to:  3 ; Changed 8 years ago by Frank

Replying to sphynx:

Adding to this, it seems we never store the oAuthToken in AIFacebookXMPPAccount.m, which means we have to ask users to login again. =/

Incorrect, see line 415.

Replying to sphynx:

However, if the account already existed, we don't request a new access_token

Correct, on password failure we should ask for a reauth.

comment:5 in reply to:  4 Changed 8 years ago by Thijs Alkemade

Replying to wixardy:

Replying to sphynx:

Adding to this, it seems we never store the oAuthToken in AIFacebookXMPPAccount.m, which means we have to ask users to login again. =/

Incorrect, see line 415.

I meant currently in 1.4.3, there that line will store the session token.

comment:6 Changed 8 years ago by Frank Dowsett <wixardy@…>

Resolution: fixed
Status: newclosed

(In 2d15405b6d71) Ask the user to login to Facebook when we get a bad password response. Fixes #15583

comment:7 Changed 8 years ago by Robert

Milestone: Adium 1.5Adium 1.4.4
Note: See TracTickets for help on using tickets.