Adium

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#15484 closed defect (fixed)

Leak in PSMTabBarControl

Reported by: kbotc Owned by:
Milestone: Adium 1.4.5 Component: Adium Core
Version: Severity: normal
Keywords: Cc:
Patch Status:

Description

Summary

When we click the "close" button in a chat, the AIChat leaks due to an extraneous retain in an imported library. You can get around this by using Command-W until we check in the library.

Regression

All versions of PSMTabBarControl before r292 leak.

Notes

This was discussed on the mailing list. I just want it documented in a ticket so that someone remembers to either rebuild and recommit it, or we bring in the exported repo.

Change History (6)

comment:1 Changed 9 years ago by Robert

Milestone: Adium 1.4.4

comment:2 Changed 9 years ago by Robert

Mercurial repository of PSMTabBarControl be here: https://bitbucket.org/sholt/psmtabbarcontrol.

comment:3 Changed 9 years ago by Robert

Milestone: Adium 1.4.4Adium 1.4.5

comment:4 Changed 9 years ago by Adrian Godoroja <robotive@…>

Resolution: fixed
Status: newclosed

(In c29e6776b1b5) Updated PSMTabBarControl to r292. Fixes #15484.

comment:5 Changed 9 years ago by Robert

I suppose this should also be applied to Trunk?

comment:6 Changed 9 years ago by Adrian Godoroja

I think this was added to trunk a few months ago, in e8e7643c539b

I'll contact sholt, just in case.

Last edited 9 years ago by Paul Wilde (previous) (diff)
Note: See TracTickets for help on using tickets.