Adium

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#15394 closed enhancement (fixed)

Lion scrollbars

Reported by: mathuaerknedam Owned by:
Milestone: Adium 1.4.3 Component: Message View
Version: 1.4.3 Severity: normal
Keywords: Lion 10.7 overlay scrollers Cc:
Patch Status:

Description

Adium's use of custom scrolbars means that we don't get the scrollbar shiny in Lion. Our custom scrollbars support the focus/mention/user marks, and we don't want to lose that.

It looks like new code for this is in Chromium (I tested build 96024) and discussed at https://code.google.com/p/chromium/issues/detail?id=74057. Can we reuse their code?

Attachments (2)

Screen Shot 2011-08-11 at 2.30.32 PM.png (224.9 KB) - added by mathuaerknedam 8 years ago.
limechat's mention markers
Screen Shot 2011-08-11 at 2.12.08 PM.png (130.1 KB) - added by mathuaerknedam 8 years ago.
Chromium's search markers

Download all attachments as: .zip

Change History (13)

comment:1 Changed 8 years ago by Robby

According to LordDragon in #adium LimeChat also has that.

I found these corresponding pull request for LimeChats on GitHub:

comment:2 Changed 8 years ago by Robby

  • Keywords Lion 10.7 added
  • Milestone set to Good ideas for later

Changed 8 years ago by mathuaerknedam

limechat's mention markers

Changed 8 years ago by mathuaerknedam

Chromium's search markers

comment:3 Changed 8 years ago by mathuaerknedam

I attached pics of each App's markers. Their behavior is the same, with the marks appearing only when the scrollbar is visible,
though the appearance is different. Limechat's are a bit undersized and Chrome's are a bit oversized.

comment:4 Changed 8 years ago by mathuaerknedam

I'm hoping that #12739 will be fixed while implementing this.

comment:5 Changed 8 years ago by Thijs Alkemade <thijsalkemade@…>

(In d29e1b34966c) This turns on the Lion overlay scrollers. The markings seem to still work, but they look a bit small to me.

Refs #15394

comment:6 Changed 8 years ago by winterk

Personally I've always preferred the old always-visible scrollbars over the new shiny overlay type. Is there any possibility to make these an optional checkbox feature?

comment:7 Changed 8 years ago by robotive

Hi winterk,

the short answer is NO, and there probably won't be one. If you don't like overlay scrollers, the best way to get rid of them is to disable them using System Preferences in OS X.

Last edited 8 years ago by robotive (previous) (diff)

comment:8 follow-up: Changed 8 years ago by robotive

  • Milestone Good ideas for later deleted
  • Resolution set to fixed
  • Status changed from new to closed
  • Version set to 1.4.3

We should also discourage the usage of custom scrollers in message views, or remove support for them, in future versions.

comment:9 Changed 8 years ago by robotive

  • Keywords overlay scrollers added

comment:10 Changed 8 years ago by Robby

  • Milestone set to Adium 1.4.3

comment:11 in reply to: ↑ 8 Changed 8 years ago by mathuaerknedam

Replying to robotive:

We should also discourage the usage of custom scrollers in message views, or remove support for them, in future versions.

  1. Why would we want to discourage the use of custom scrollers?
  2. Considering that the "standard" way to do implement custom scrollers is to use javascript to move elements so that a custom element has css overflow scrolling (it's not a window scroller), I think it would be very difficult to remove support for custom scrollers without creating a new class of message style that prohibits either custom javascript or (maybe) custom versions of template.html. I don't think the former would be a good idea, and as long as we allow custom javascript, the motivated will work around the latter. (I *do* think that mvv=5 should prohibit a custom template.html, but not for this reason.)
Note: See TracTickets for help on using tickets.