Adium

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#15256 closed defect (fixed)

Consider using libpurple's MSNp15 support instead of p16

Reported by: Robby Owned by:
Milestone: Adium 1.4.3 Component: Service/MSN
Version: 1.4.2 Severity: normal
Keywords: Cc: Dimmuxx
Patch Status:

Description

Summary

For Adium 1.4.2 we updated libpurple to 2.7.11. This fixed a couple of major problems (connection issues, a common crash) but broke file transfer, contact icons and receiving custom emoticons http://adium.im/blog/2011/06/adium-1-4-2/ has the details).

Dimmuxx suggested using libpurple's MSNp15 support:

all the msn fixes are fixed in msnp15 too and the only thing missing is mpop.

it's just changing one line in the latest version

or two lines at around line 115 in libpurple/protocols/msn/msn.h

define WLM_PROT_VER 16->15 and define WLM_MAX_PROTOCOL 16->15

been running pidgin like that since 16 broke

I'm not sure whether removing mpop support will bring back #13654.

Change History (5)

comment:1 Changed 8 years ago by Robby

  • Cc Dimmuxx added
  • Milestone set to Adium 1.4.3

Care to comment on that last question, Dimmuxx?

comment:2 Changed 8 years ago by Dimmuxx

I'm not sure if it's fixed in latest libpurple regardless if using 15 or 16. I Haven't experienced the issue at all.

comment:3 Changed 8 years ago by Evan Schoenberg

  • Resolution set to fixed
  • Status changed from new to closed

(In 42caafcfe810) im.pidgin.adium.1-4 @ 9fa905dc57b224f6ecc51361480da7be9668055c with MSNp15 enabled (downgrading from MSNp16). It connects and lets me send messages. Beyond that, someone who uses MSN needs to test it :)

Fixes #15256. Note that this is only on adium-1.4; I'm not recompiling adium 1.5's libpurple at this time.

comment:4 Changed 7 years ago by fuzzy76

Is there any issue for discussing the return to MSNp16, or is this it?

comment:5 Changed 7 years ago by Robby

AdiumVersionHistory [Version 1.5.1]:

MSN: Switched to MSN protocol version 18, therefore re-enabling Multiple Points of Presence support.

Note: See TracTickets for help on using tickets.