Adium

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#15183 closed enhancement (fixed)

Group chat should support purple images

Reported by: pfung Owned by:
Milestone: Adium 1.5 Component: Libpurple
Version: 1.5hg Severity: normal
Keywords: Cc:
Patch Status: Accepted

Description

Summary

Group chat should support purple images (imgstore tags) as what IM chat does, but Adium drops all those tags currently.

Steps to reproduce

N/A

Expected results

Group chat supports purple images.

Actual results

All purple imgstore tags are dropped in a group chat.

Regression

N/A

Notes

I've made a patch to the file adiumPurpleConversation.m to fix this issue. Please see the attachment. Thanks.

Attachments (2)

myPatch.diff (995 bytes) - added by pfung 9 years ago.
1.diff (1.1 KB) - added by pfung 9 years ago.

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by pfung

comment:1 Changed 9 years ago by Robby

  • Milestone set to Adium 1.5

Thanks!

comment:2 Changed 9 years ago by pfung

I'm sorry. I made some mistake in my patch. I will resubmit the patch later.

comment:3 Changed 9 years ago by Robby

  • Patch Status changed from Needs Dev Review to Needs Changes by Author

Don't worry. :)

Changed 9 years ago by pfung

comment:4 Changed 9 years ago by pfung

It's ok now. I've compiled and tested it. Thanks.

comment:5 Changed 9 years ago by Robby

  • Patch Status changed from Needs Changes by Author to Needs Dev Review

comment:6 Changed 8 years ago by Peter Fung <appfung@…>

  • Resolution set to fixed
  • Status changed from new to closed

(In a3eba9e4f705) Group chat should support purple images (custom emoticons etc.)

Fixes #15183, r=xnyhps

comment:7 Changed 8 years ago by sphynx

  • Patch Status changed from Needs Dev Review to Accepted

comment:8 Changed 8 years ago by pfung

Thank you~

comment:9 Changed 8 years ago by Robert Vehse

(In 230d8e1fc93f) Changelog and credit Peter Fung for his patches. Refs #15183, refs #15186.

Note: See TracTickets for help on using tickets.