Adium

Opened 9 years ago

Closed 9 years ago

#15047 closed patch (fixed)

AIListOutlineView is leaking when closing the Contact List.

Reported by: ROBOTIVE Owned by: robotive
Milestone: Adium 1.4.2 Component: Adium Core
Version: 1.4.1 Severity: normal
Keywords: memory leaks AIListOutliveView Cc:
Patch Status: Accepted

Description

Summary

AIListOutliveView is leaking when closing the Contact List.

Steps to reproduce

Using Instruments > Leaks:

  1. Start Adium
  2. Close the Contact List

Expected results

No memory leaks.

Actual results

Right, memory leaks :)

Notes

AILitsOutlineView is a mess :P

There may be other leaks here, i've managed to fix those that a tracked by Instruments > Leaks.

Patch

Patches are included for both: 1.4.2hg and 1.5hg

Attachments (4)

Adium_1_4hg_leaks.patch (4.5 KB) - added by ROBOTIVE 9 years ago.
Adium_1_5hg_leaks.patch (2.2 KB) - added by ROBOTIVE 9 years ago.
Adium-1_4hg-15047-r2.patch (799 bytes) - added by robotive 9 years ago.
Adium-1_5hg-15047-r2.patch (801 bytes) - added by robotive 9 years ago.

Download all attachments as: .zip

Change History (13)

Changed 9 years ago by ROBOTIVE

Changed 9 years ago by ROBOTIVE

comment:1 Changed 9 years ago by Robby

  • Milestone set to Adium 1.4.2
  • Patch Status changed from Initially Included to Needs Dev Review

comment:2 Changed 9 years ago by robotive

  • Owner set to robotive

comment:3 Changed 9 years ago by David Munch

  • Type changed from defect to patch

comment:4 Changed 9 years ago by Robby

  • Patch Status changed from Needs Dev Review to Accepted
  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 9 years ago by Robert Vehse

(In 4be677112537) Changelog updates, small AdiumHelp fix. Refs #15047.

comment:6 Changed 9 years ago by Robby

  • Summary changed from AIListOutliveView is leaking when closing the Contact List. to AIListOutlineView is leaking when closing the Contact List.

Changed 9 years ago by robotive

Changed 9 years ago by robotive

comment:7 Changed 9 years ago by robotive

  • Patch Status changed from Accepted to Needs Dev Review
  • Resolution fixed deleted
  • Status changed from closed to new

comment:8 Changed 9 years ago by robotive

Fixed two more leaks!

comment:9 Changed 9 years ago by Robby

  • Patch Status changed from Needs Dev Review to Accepted
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.