Adium

Opened 9 years ago

Last modified 8 years ago

#14493 new defect

Contact doesn't highlight when typing despite pref

Reported by: cepheid Owned by:
Milestone: Component: Adium UI
Version: 1.4 Severity: regression
Keywords: typing indicator highlight contact list Cc:
Patch Status: Accepted

Description (last modified by Robby)

Summary

I have my preferences set to highlight a buddy as orange when the buddy is typing. In v1.4, this does not occur. This is a new bug - previous versions would properly highlight users who are typing.

Steps to reproduce

  1. Open the buddy list.
  2. Make sure prefs are set so buddies highlight when typing.
  3. Have a buddy type.
  4. Notice that he doesn't highlight.

Expected results

Contact in buddy list should highlight when typing.

Actual results

Contact doesn't highlight.

Regression

This is new as of v1.4. Previous versions worked properly.

Notes

Screenshot attached. The buddy who is typing is not highlighted, but should be.

Attachments (4)

buddy_not_highlighted.png (15.7 KB) - added by cepheid 9 years ago.
Buddy list - contact who is typing is not highlighted, but should be
prefs.png (39.9 KB) - added by cepheid 9 years ago.
Prefs showing that typing buddies should be highlighted
ticket14493.hgbundle (1.2 KB) - added by gordolio 8 years ago.
fix to 14493
adium_143_no_highlight.png (11.2 KB) - added by cepheid 8 years ago.
Adium 1.4.3, buddy not highlighting

Download all attachments as: .zip

Change History (28)

Changed 9 years ago by cepheid

Buddy list - contact who is typing is not highlighted, but should be

Changed 9 years ago by cepheid

Prefs showing that typing buddies should be highlighted

comment:1 Changed 9 years ago by Robby

  • Milestone set to Adium 1.4.1
  • Severity changed from normal to regression

Thanks!

comment:2 Changed 9 years ago by zacw

Is the contact in question a meta contact? (Hover over their name in the contact list, if it contains multiple entries, it's a meta contact.)

comment:3 Changed 9 years ago by cepheid

This one, yes. I haven't yet noticed if this happens for non-meta contacts.

comment:4 Changed 9 years ago by Robby

  • Description modified (diff)

comment:5 Changed 9 years ago by cepheid

OK, a couple more things to note:

  1. The same contact also does not flash blue to indicate unread messages.
  2. A different contact (also a meta-contact) DOES flash blue to indicate unread messages, but only sometimes ... I can't tell for sure why sometimes yes and sometimes no, although I suspect that it has to do with Adium being the foreground app - when Adium is in FG, AFAIK it won't highlight blue even if the contact window doesn't have focus; the highlight seems to occur only when Adium is not the FG app. This is a change from previous behavior, where the contact would highlight blue as long as the window didn't have focus, even if Adium itself was the FG app.
  3. Possibly unrelated, and reported earlier (though I can't find the bug at this time), but contacts with unread messages don't FLASH blue, they simply highlight a solid blue. I have my preferences set to flash, but Adium seems to ignore that preference and simply highlights solid. If I disable and re-enable the preference, the contact will flash again, but only until I quit Adium - upon next startup, the preference is again ignored and the highlight is solid, not flashing.

Hope this helps - let me know if you need more info, more screenshots, or more testing.

comment:6 Changed 9 years ago by cepheid

Hmm, OK, ignore the speculation in #2. It has nothing to do with FG versus not. The highlight just seems to appear sometimes, and sometimes not. No idea why not. However... for that same contact that does sometimes highlight, Adium is no longer notifying me (at all, even through the "pencil" icon) that the contact is typing. She has not adjusted her preferences, so Adium should be notifying me, but is not.

comment:7 Changed 9 years ago by cepheid

More weirdness. The contact that does sometimes highlight also sometimes notifies me that she's typing, and does highlight orange! The only difference between these two contacts is that the one that sometimes works is logged into only one account, while the one that never works is logged simultaneously into AIM, Yahoo, and GChat.

comment:8 Changed 9 years ago by Evan Schoenberg

  • Resolution set to fixed
  • Status changed from new to closed

(In 3429fa3628c5) Fixed contact status background colors updating in the contact list, including both static and flashing statuses. Fixes #14534. Fixes #14493.

comment:9 Changed 9 years ago by cepheid

Unfortunately, this bug is not fixed. I am experiencing the exact same lack of coloring with v1.4.1 as I did with v1.4. The same screenshots apply, so I am not including new ones.

Apparently this issue extends beyond whatever was fixed... there's something else going on causing the buddy to not be colored properly. The buddy is neither orange when typing, nor blue (flashing or otherwise) with unread messages.

comment:10 Changed 9 years ago by cepheid

Although I should note again that this seems to only affect some metacontacts, and not others... for example, I have myself as a metacontact, and I do highlight properly when typing a message to myself.

For the metacontact where this consistently fails (James, in the screenshot), when expanding the contact as recommended in bug #14534, the colors do update properly for the individual buddy within the metacontact.

comment:11 Changed 9 years ago by Robby

  • Milestone changed from Adium 1.4.1 to Adium 1.4.2
  • Resolution fixed deleted
  • Status changed from closed to new

comment:12 Changed 9 years ago by evands

  • Milestone changed from Adium 1.4.2 to Adium 1.4.3

1.4.2 is for security fixes, a libpurple update, and Facebook XMPP. All other issues are being bumped.

comment:13 Changed 9 years ago by David Munch

  • Keywords typing indicator highlight contact list added

comment:14 Changed 8 years ago by evands

Ticket #14534 has been marked as a duplicate of this ticket.

Changed 8 years ago by gordolio

fix to 14493

comment:15 Changed 8 years ago by gordolio

I managed to find a simple solution for this one. It's just a 1 line fix in AIMetaContact.m

The highlight would only occur on the meta contact when the preferred contact was typing. If any non-preferred contact was typing, then the meta contact would not hilight.

comment:16 Changed 8 years ago by Robby

  • Patch Status set to Needs Dev Review

Neat, thanks!

comment:17 Changed 8 years ago by ShawnRisk

I tested out this ticket with 1.5hg and this works out. I had to go into Preferences, Appearances, Color Theme (Customize), Events, and Check Typing which is what the screenshot above shows.

comment:18 Changed 8 years ago by Thijs Alkemade <thijsalkemade@…>

  • Resolution set to fixed
  • Status changed from new to closed

(In 8edc9f32d9ff) When a subcontact of a metacontact is typing or has unviewed content, apply the status coloring to the metacontact as well, so the metacontact gets highlighted even if this subcontact is not the prefered contact.

Fixes #14493

comment:19 Changed 8 years ago by Gordon Child <gordon@…>

(In 14685b7a7900) Fixed ticket 14493 - Contact doesn't highlight when typing despite pref

Prior to the fix, the highlight would only occur on the meta contact when the preferred contact was typing. If any non-preferred contact was typing, then the meta contact would not hilight.

The fix was to remove "isEvent" from the list of forwarded properties in AIMetaContact

Refs #14493, r=xnyhps

comment:20 Changed 8 years ago by sphynx

gordolio: Thanks for the patch! Your diagnosis was right for the adium branch, but to completely fix it, and also fix it on the adium-1.4 branch I had to make some other changes as well.

comment:21 Changed 8 years ago by Robby

  • Patch Status changed from Needs Dev Review to Accepted

comment:22 Changed 8 years ago by cepheid

Unfortunately, this patch has not fixed the problem. This bug needs to be reopened. I'm attaching a screenshot taken today with Adium 1.4.3 on OS X 10.6.8. See the second buddy - the typing indicator shows up, but the buddy is not colored orange. It should be noted that this is a meta-contact and the "active" contact is second on the list, so it's not the "preferred" contact. I'm not sure why it would be "immune" from the patch, but that's how it appears...

Was the patch not implemented in 1.4.3, despite the Milestone? Or was it implemented and isn't working, for some reason?

Thanks.

Changed 8 years ago by cepheid

Adium 1.4.3, buddy not highlighting

comment:23 Changed 8 years ago by cepheid

I should note, however, that a different buddy (the one in the first attachment, buddy_not_highlighted.png) _is_ highlighting properly, even though he is also a meta-contact with the non-preferred contact typing. Therefore, there appears to be more at work here than simply it being the non-preferred contact in a meta, since I've got two meta contacts who behave differently, one showing the bug and one not.

Very strange. Please let me know how I can help you to debug.
Thanks.

comment:24 Changed 8 years ago by Robby

  • Milestone Adium 1.4.3 deleted
  • Resolution fixed deleted
  • Status changed from closed to new
Note: See TracTickets for help on using tickets.