Adium

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#14357 closed enhancement (fixed)

Double Confimation/Alert when Removing Jabber Account from the Server

Reported by: xmppjingle Owned by:
Milestone: Adium 1.4.2 Component: Service/XMPP (Jabber)
Version: Severity: normal
Keywords: Cc:
Patch Status: Accepted

Description (last modified by Robert)

Summary

Adium is not confirming and alerting the end user properly about deleting account at the server.

Steps to reproduce

  1. Add a Jabber Account.
  2. Login
  3. Go to Account manager panel
  4. Click on "-" to remove the account
  5. Click on "Delete and Unregister"

Expected results

An Alert explaining that the account will be removed also from the server, "Do you want to continue?".

Actual results

Account is removed from Adium and also Jabber Server.

Regression

Always

Notes

This is critical for new Adium Jabber users, I already heard several reports of people loosing accounts, and stopping using Adium due this.

Attachments (2)

adium_jabber_confirm.patch (981 bytes) - added by Thiago Camargo 10 years ago.
Patch to Include an extra COnfirmation Dialog Explaining the Behavior and Risks.
adium_jabber_confirm_new.patch (1.9 KB) - added by Thiago Camargo 10 years ago.
New Pacth With Extra Check when Account not logged in

Download all attachments as: .zip

Change History (13)

Changed 10 years ago by Thiago Camargo

Attachment: adium_jabber_confirm.patch added

Patch to Include an extra COnfirmation Dialog Explaining the Behavior and Risks.

comment:1 Changed 10 years ago by Robert

Description: modified (diff)
Milestone: Adium 1.5
Patch Status: Initially IncludedNeeds Dev Review

Cool! :)

comment:2 Changed 10 years ago by Thijs Alkemade

Patch Status: Needs Dev ReviewNeeds Changes by Author
Status: newpending

Hey, nice to see you've finished your patch. :)

But this will only show the warning when the account is online at the moment of deletion, are you sure that's what you want to do?

Changed 10 years ago by Thiago Camargo

New Pacth With Extra Check when Account not logged in

comment:3 Changed 10 years ago by Thiago Camargo

Status: pendingnew

Attachment (adium_jabber_confirm_new.patch) added by ticket reporter.

comment:5 Changed 10 years ago by Thiago Camargo

Added new Version of the patch with enhanced behavior to also cover Alert, when user is not logged id.

comment:6 Changed 10 years ago by Moses Lei

Ticket #14355 has been marked as a duplicate of this ticket.

comment:7 Changed 10 years ago by Thiago Camargo

Needed changes already submitted. Waiting for feedback.

comment:8 Changed 10 years ago by Moses Lei

Patch Status: Needs Changes by AuthorNeeds Dev Review

comment:8 Changed 10 years ago by Thijs Alkemade <thijsalkemade@…>

Resolution: fixed
Status: newclosed

(In 603694d9bafb) Double confirmation is now required to delete and unregister an IRC account. Based on a patch from xmppjingle.

Fixes #14357

comment:9 Changed 10 years ago by Robert

Patch Status: Needs Dev ReviewAccepted

Needless to say, that is supposed to read "XMPP", not "IRC".

Thanks, xmppjingle!

comment:10 Changed 10 years ago by Thijs Alkemade <thijsalkemade@…>

(In ffae91fa6b57) Double confirmation is now required to delete and unregister an XMPP account. Based on a patch from xmppjingle.

Fixes #14357

comment:11 Changed 10 years ago by Robert

Milestone: Adium 1.5Adium 1.4.2

This was also applied to 1.4.2. :)

Last edited 10 years ago by Robert (previous) (diff)
Note: See TracTickets for help on using tickets.