Adium

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#13987 closed enhancement (fixed)

Twitter's tabcomplete should add the @ sign

Reported by: paradoxmo Owned by: paradoxmo
Milestone: Adium 1.4.1 Component: Service/Twitter
Version: Severity: normal
Keywords: autocomplete Cc:
Patch Status: Accepted

Description

Following up on #13986. If we aren't going to limit tab completion to only after @, we should complete the @ for the user. i.e.:

parad<TAB> -> @paradoxmo

Also we should not add : even at the beginning of the line for Twitter.

Attachments (2)

autocomplete-prefix-munging.patch (1.5 KB) - added by Moses Lei 10 years ago.
Patch to make the cursor appear at the right place when adding a prefix
autocomplete-prefix-cleanup.patch (1005 bytes) - added by Moses Lei 10 years ago.
Remove prefix code path that will never be used

Download all attachments as: .zip

Change History (19)

comment:1 Changed 10 years ago by Robert

Milestone: Adium 1.5
Owner: changed from Zachary West to Moses Lei

Tentatively setting 1.5. If it gets fixed for an earlier release, all the better.

comment:2 Changed 10 years ago by William Bowling

Patch Status: Needs Dev Review

Patch at ff6fae3388e1 that allows account types to specify a prefix or suffix for tab completing if they require, and the suggested twitter functionality implemented.

comment:3 Changed 10 years ago by Moses Lei

Just read this patch, and it looks good at first glance. I will patch my install and verify this weekend.

comment:4 Changed 10 years ago by William Bowling

Added a check to see if the prefix/suffix already exists 051889f9742b

comment:5 Changed 10 years ago by Moses Lei

I've been testing this with wbowling on IRC. There's still a slight bug.

If I type: p<tab> and it completes to "@paradoxmo", "paradoxmo" is selected, while it should be "aradoxmo". It does this because the text shifted one by the addition of the prefix, and so the old charRange.location no longer matches the completed text.

comment:6 Changed 10 years ago by Moses Lei

This fixes it, I think. Apply the above two changesets then apply the attached patch.

Changed 10 years ago by Moses Lei

Patch to make the cursor appear at the right place when adding a prefix

comment:7 Changed 10 years ago by William Bowling

Trying out bitbuckets patch queues, lets see how it goes. The current three patches combined at autocomplete.patch

comment:8 Changed 10 years ago by Robert Vehse

Resolution: fixed
Status: newclosed

(In a534d21369d5) Fixes #13987. Allow accounts to override the suffix/prefix for chat autocomplete. Add the "@" sign as a prefix and remove ":" as a suffix for Twitter. "mlei" and "wbowling" worked together on this patch.

comment:9 Changed 10 years ago by Robert

Patch Status: Needs Dev ReviewAccepted
Type: defectenhancement

Good job, guys. :)

comment:10 Changed 10 years ago by Moses Lei

I forgot to remove this code path that will never be used, attaching patch to remove it.

Changed 10 years ago by Moses Lei

Remove prefix code path that will never be used

comment:11 Changed 10 years ago by Robert Vehse

(In 0e3dafd316e8) Remove prefix code path that will never be used. Refs #13987. Patch by "mlei". Thanks!

comment:12 Changed 10 years ago by Moses Lei

This needs to be committed to 1.4 too, it doesn't look like that's been done.

comment:13 Changed 10 years ago by Robert

Milestone: Adium 1.5Adium 1.4

Transplanted to 1.4 in 961833271e26 and 85903a7dd4f3.

comment:14 Changed 10 years ago by Robert

Keywords: 1.4.1 added

comment:15 Changed 10 years ago by Zachary West <zacw@…>

(In d4b6a044b645) Backed out changeset 85903a7dd4f3

Let's wait for 1.4.1 to make any further non-vital changes.

Refs #13987.

comment:16 Changed 10 years ago by Robert

Keywords: backport-1.4.1 added; 1.4.1 removed
Milestone: Adium 1.4Adium 1.4.1

comment:17 Changed 10 years ago by Robert

Keywords: backport-1.4.1 removed

Hm, that doesn't seem to work. I'll just keep a list on my computer.

Note: See TracTickets for help on using tickets.