Adium

Opened 10 years ago

Closed 8 years ago

Last modified 7 years ago

#13947 closed defect (fixed)

Twitter parsing does not conform to the standard

Reported by: pepijndevos Owned by: zacw
Milestone: Adium 1.5.7 Component: Service/Twitter
Version: Severity: minor
Keywords: Twitter, regex, hastag Cc:
Patch Status:

Description (last modified by Robert)

Summary

Adium matches hashtags it shouldn't, like #8

Steps to reproduce

  1. Create a Twitter account
  2. send a tweet containing a numbers-only hashtag

Expected results

The hashtag should be displayed as-is

Actual results

The hashtag displayed as a link, but the search page returned no results, because it is an invalid tag.

Regression

This and probably other inconsistencies occur at least with Adium 1.4 Beta, but I suspect all versions with Twitter support to have the same problem.

Notes

A test suit for twitter parsers: http://github.com/mzsanford/twitter-text-conformance


Edit: The above repository with test suite for twitter parsers has been deprecated in favour of https://github.com/twitter/twitter-text-conformance/commits/master.

Change History (9)

comment:1 Changed 10 years ago by Robert

Description: modified (diff)

comment:2 Changed 10 years ago by Robert

Milestone: Adium 1.4

comment:3 Changed 10 years ago by Robert

Milestone: Adium 1.4Adium 1.4.x
Severity: normalminor

comment:4 Changed 10 years ago by Robert

Milestone: Adium 1.4.xAdium bugs

comment:5 Changed 8 years ago by Frank Dowsett <wixardy@…>

Resolution: fixed
Status: newclosed

(In 7d45cfb6ae92) No more t.co links! (Well, almost none).

Use the entities that Twitter sends to parse and link URLs, users, and hashtags. Fixes #13947

comment:6 Changed 8 years ago by Frank

Milestone: Adium bugsAdium 1.6

comment:7 Changed 7 years ago by Frank Dowsett <wixardy@…>

(In bff389662124) Upgrade Twitter to API 1.1 by switching from MGTwitterEngine to STTwitter. (Collapsed revision version) (transplanted from a1f0282331b815ef25f63df09a5954fe0928d466) (transplanted from 75e25d1deff2aa9bc8d7cff2aa6bc4e117c01064)

  • Fix some memory management from the transplant.
  • Update STTwitter to remove nulls from returned data.
  • This is the method we want to call.
  • Need to send something with the retweet request in order for it to authenticate properly.
  • Our buildbot doesn't like this new dictionary syntax, it seems.
  • Fix STTwitter to use ivars and @synthesize all properties, and not use [] syntax for dictionaries or arrays, so it can work on 32 bit Macs.
  • Fix Twitter account creation.
  • Use Matt Gallagher's NSData+Base64 for 10.6 compat.
  • NSURLConnection blocks don't work on 10.6 either.
  • No more t.co links! (Well, almost none).

Use the entities that Twitter sends to parse and link URLs, users, and hashtags. Fixes #13947

  • Stupid me stupidly thought the computers would do what I was thinking for me.
  • nextPageNecessary is no longer necessary.
  • Fix 3 leaks in STTwitterAPIWrapper.m.
  • Fixed another leak in STTwitterAPIWrapper.m.
  • Bring STTwitter more up to date with what's on github (specifically, merge a leak fix from upstream).

comment:8 Changed 7 years ago by Robert

Milestone: Adium 1.6Adium 1.5.7

comment:9 Changed 7 years ago by Robert

Description: modified (diff)
Note: See TracTickets for help on using tickets.