Adium

Opened 10 years ago

Closed 9 years ago

#13612 closed defect (fixed)

Arabic text is always left-aligned

Reported by: mamouneyya Owned by:
Milestone: Adium 1.4 Component: Message View
Version: 1.3.8 Severity: normal
Keywords: rtl, arabic, alignment Cc:
Patch Status:

Description

Summary

When you send/receive an Arabic texts, they are shown left-aligned instead of right.

Steps to reproduce

Send or ask someone to send an Arabic text to you (you can try with: السلام عليكم)

Expected results

You should see it right-aligned. (see expected.png)

Actual results

You will see it left-aligned. (see actual.png)

Attachments (2)

expected.png (15.0 KB) - added by mamouneyya 10 years ago.
actual.png (14.8 KB) - added by mamouneyya 10 years ago.

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by mamouneyya

Changed 10 years ago by mamouneyya

comment:1 Changed 10 years ago by jas8522

  • Status changed from new to pending

Please try this with the AdiumBeta.

comment:2 Changed 10 years ago by zacw

The beta probably won't change anything, I can't recall any HTML changes between the two for RTL. Try it though, maybe something changed I don't remember.

From what client are they sending? I believe iChat sends the RTL tag improperly or as a body element which we drop. Adium<->Adium should work superbly.

A debug log would be helpful. See CurrentAdiumDebug for instructions, but do it from the 1.4 beta.

comment:3 Changed 10 years ago by mamouneyya

  • Status changed from pending to new

The same thing in Beta version.

Replying to zacw:

From what client are they sending? I believe iChat sends the RTL tag improperly or as a body element which we drop. Adium<->Adium should work superbly.

iChat doesn't support MSN protocol, which I'm using Adium for. Some of my Mac contacts are using Adium it-self and others are using Messenger Live from Windows.

A debug log would be helpful. See CurrentAdiumDebug for instructions, but do it from the 1.4 beta.

I've submitted it via the mentioned email.

comment:4 Changed 9 years ago by David Munch

  • Milestone set to Adium bugs

Could you also submit it in this

comment:5 Changed 9 years ago by mamouneyya

This was the log I had gotten:
[code]
19:32:51: (Libpurple: msn) send IM {<FONT FACE="Geeza Pro">السلام عليك} to @*.com
19:32:51: (Libpurple: msn) prepare to send online Message
19:32:51: (Libpurple: msn) send via switchboard
19:32:51: (Libpurple: msn) new httpconn (0x1f258d50)
19:32:51: (Libpurple: msn) C: NS 000: XFR 22 SB
19:32:51: (Libpurple: msn) switchboard send msg..
19:32:51: (Libpurple: msn) Appending message to queue.
19:32:52: (Libpurple: msn) S: NS 000: XFR 22 SB 64.4.9.30:1863 CKI 1315044758.137124189.185149222 U messenger.msn.com 1
19:32:52: (Libpurple: msn) Switchboard:auth:{1315044758.137124189.185149222} socket:{64.4.9.30:1863}
19:32:52: (Libpurple: dns) DNS query for '64.4.9.30' queued
19:32:52: (Libpurple: dnsquery) IP resolved for 64.4.9.30
19:32:52: (Libpurple: proxy) Attempting connection to 64.4.9.30
19:32:52: (Libpurple: proxy) Connecting to 64.4.9.30:1863 with no proxy
19:32:52: (Libpurple: proxy) Connection in progress
19:32:52: (Libpurple: proxy) Connecting to 64.4.9.30:1863.
19:32:52: (Libpurple: proxy) Connected to 64.4.9.30:1863.
19:32:52: (Libpurple: msn) C: SB 007: USR 1 ####@hotmail.com 1315044758.137124189.185149222
19:32:53: (Libpurple: msn) S: SB 007: USR 1 OK ####@hotmail.com ####%40hotmail.com
19:32:53: (Libpurple: msn) C: SB 007: CAL 2
@*.com
19:32:53: (Libpurple: msn) S: SB 007: CAL 2 RINGING 1315044758
19:32:54: (Libpurple: msn) S: SB 007: JOI @*.com Ma'moun 1073741856
19:32:54: (Libpurple: msn) Processing queue
19:32:54: (Libpurple: msn) Sending message
19:32:54: (Libpurple: msn) C: SB 007: MSG 3 A 170
19:32:54: (Libpurple: msn) switchboard send msg..
19:32:54: (Libpurple: msn) C: SB 007: MSG 4 U 103
19:32:54: (Libpurple: msn) S: SB 007: ACK 3
19:32:55: (Libpurple: msn) send IM {<FONT FACE="Geeza Pro">كيفك أخبارك؟!} to
@*.com
19:32:55: (Libpurple: msn) prepare to send online Message
19:32:55: (Libpurple: msn) send via switchboard
19:32:55: (Libpurple: msn) switchboard send msg..
19:32:55: (Libpurple: msn) C: SB 007: MSG 5 A 173
19:32:56: (Libpurple: msn) S: SB 007: ACK 5
19:32:59: (Libpurple: msn) S: SB 007: MSG @*.com Ma'moun 92
19:33:00: (Libpurple: msn) S: SB 007: MSG
@*.com Ma'moun 157
19:33:00: adiumPurpleConvWriteIm: Received <FONT FACE="Geeza Pro"><FONT COLOR="#000000">هلا هلا</FONT></FONT> from @*.com
19:33:00: Posting Growl notification: Event ID: Content_MessageReceivedBackground, listObject: <AIListContact:1b66e460 MSN.****@*******.com>, chat: <AIChat: 0x18584e10>:MSN.
@*.com, description: هلا هلا
19:33:25: (Libpurple: msn) destroy httpconn (0x1b6dbc50)
19:33:28: (Libpurple: msn) C: NS 000: PNG
19:33:28: (Libpurple: msn) S: NS 000: QNG 42
[code]

comment:6 Changed 9 years ago by mamouneyya

Sorry. I haven't used the right shortcode for code:

19:32:51: (Libpurple: msn) send IM {<FONT FACE="Geeza Pro">السلام عليك} to ****@*******.com
19:32:51: (Libpurple: msn) prepare to send online Message
19:32:51: (Libpurple: msn) send via switchboard
19:32:51: (Libpurple: msn) new httpconn (0x1f258d50)
19:32:51: (Libpurple: msn) C: NS 000: XFR 22 SB
19:32:51: (Libpurple: msn) switchboard send msg..
19:32:51: (Libpurple: msn) Appending message to queue.
19:32:52: (Libpurple: msn) S: NS 000: XFR 22 SB 64.4.9.30:1863 CKI 1315044758.137124189.185149222 U messenger.msn.com 1
19:32:52: (Libpurple: msn) Switchboard:auth:{1315044758.137124189.185149222} socket:{64.4.9.30:1863}
19:32:52: (Libpurple: dns) DNS query for '64.4.9.30' queued
19:32:52: (Libpurple: dnsquery) IP resolved for 64.4.9.30
19:32:52: (Libpurple: proxy) Attempting connection to 64.4.9.30
19:32:52: (Libpurple: proxy) Connecting to 64.4.9.30:1863 with no proxy
19:32:52: (Libpurple: proxy) Connection in progress
19:32:52: (Libpurple: proxy) Connecting to 64.4.9.30:1863.
19:32:52: (Libpurple: proxy) Connected to 64.4.9.30:1863.
19:32:52: (Libpurple: msn) C: SB 007: USR 1 ####@hotmail.com 1315044758.137124189.185149222
19:32:53: (Libpurple: msn) S: SB 007: USR 1 OK ####@hotmail.com ####%40hotmail.com
19:32:53: (Libpurple: msn) C: SB 007: CAL 2 ****@*******.com
19:32:53: (Libpurple: msn) S: SB 007: CAL 2 RINGING 1315044758
19:32:54: (Libpurple: msn) S: SB 007: JOI ****@*******.com Ma'moun 1073741856
19:32:54: (Libpurple: msn) Processing queue
19:32:54: (Libpurple: msn) Sending message
19:32:54: (Libpurple: msn) C: SB 007: MSG 3 A 170
19:32:54: (Libpurple: msn) switchboard send msg..
19:32:54: (Libpurple: msn) C: SB 007: MSG 4 U 103
19:32:54: (Libpurple: msn) S: SB 007: ACK 3
19:32:55: (Libpurple: msn) send IM {<FONT FACE="Geeza Pro">كيفك أخبارك؟!} to ****@*******.com
19:32:55: (Libpurple: msn) prepare to send online Message
19:32:55: (Libpurple: msn) send via switchboard
19:32:55: (Libpurple: msn) switchboard send msg..
19:32:55: (Libpurple: msn) C: SB 007: MSG 5 A 173
19:32:56: (Libpurple: msn) S: SB 007: ACK 5
19:32:59: (Libpurple: msn) S: SB 007: MSG ****@*******.com Ma'moun 92
19:33:00: (Libpurple: msn) S: SB 007: MSG ****@*******.com Ma'moun 157
19:33:00: adiumPurpleConvWriteIm: Received <FONT FACE="Geeza Pro"><FONT COLOR="#000000">هلا هلا</FONT></FONT> from ****@*******.com
19:33:00: Posting Growl notification: Event ID: Content_MessageReceivedBackground, listObject: <AIListContact:1b66e460 MSN.****@*******.com>, chat: <AIChat: 0x18584e10>:MSN.****@*******.com, description: هلا هلا
19:33:25: (Libpurple: msn) destroy httpconn (0x1b6dbc50)
19:33:28: (Libpurple: msn) C: NS 000: PNG
19:33:28: (Libpurple: msn) S: NS 000: QNG 42

comment:7 Changed 9 years ago by zacw

  • Milestone changed from Adium bugs to Adium 1.4

comment:8 Changed 9 years ago by Zachary West <zacw@…>

  • Resolution set to fixed
  • Status changed from new to closed

(In f4c2dffc9723) Fix RTL detection for Arabic (among others).

We can't just compare a bitmask with a static value; Arabic has the FRIBIDI_MASK_ARABIC (for example) applied, which makes FRIBIDI_TYPE_RTL not validate.

Just check for the presence of RTL, now.

Fixes #13612.

Note: See TracTickets for help on using tickets.