Adium

Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#13541 closed defect (fixed)

1.4b17: Date on the about dialog is clipped

Reported by: dani_ramos Owned by: berdan
Milestone: Adium 1.4.1 Component: Localization
Version: Severity: minor
Keywords: about clipping Cc:
Patch Status: Rejected

Description (last modified by Robert)

Summary

Provide a descriptive summary of the issue.

Steps to reproduce

  1. 1.4b17
  2. Check the About dialog (Go to Adium > About Adium)

Results

The date displayed in the About box is clipped.

Notes

Check attached screenshot Path: Adium.app/Contents/Resources/AboutBox.nib

Attachments (2)

US.png (49.5 KB) - added by Daniel Ramos 10 years ago.
short-date-in-about-box.patch (719 bytes) - added by Tim Horton 9 years ago.

Download all attachments as: .zip

Change History (13)

Changed 10 years ago by Daniel Ramos

Attachment: US.png added

comment:1 Changed 10 years ago by Jordan

Component: Adium UILocalization
Milestone: Adium 1.4 (Release)
Owner: set to Daniel Bergman
Severity: normalminor

It's fine in English - localization spacing issue.

comment:2 Changed 10 years ago by Robert

Description: modified (diff)

comment:3 Changed 10 years ago by Daniel Ramos

This issue is not a localization spacing issue as the nib is not on the localized folder (as you can see by it's path) and the date displayed is the same as the OS complete date.
In English is fine because the complete date (Wednesday, December 2, 2009) is much shorter than for pt_PT (quarta-feira, 2 de Dezembro de 2009).
The problem is just that the field either is too wide or it doesn't have a fixed size so to wrap the date correctly.

comment:4 Changed 10 years ago by Evan Schoenberg

Milestone: Adium 1.4 (Release)Adium bugs

comment:5 Changed 9 years ago by Tim Horton

What's the correct way to solve this? We could ellipsize the text, or expand the window, or just use a shorter date format and hope it doesn't overflow then?

comment:6 Changed 9 years ago by Zachary West

Using a shorter date would be a valid solution.

comment:7 Changed 9 years ago by Robert

I agree with sphynx who said it would be fine to allow the text to span multiple lines. The icon might need to be made smaller to accomodate, though.

By the way, the icon isn't centred currently, is it?

comment:8 Changed 9 years ago by Tim Horton

If we want the shorter date solution, here's a patch. The icon does look slightly off-center, too, yeah.

Changed 9 years ago by Tim Horton

comment:9 Changed 9 years ago by Robert

Patch Status: Needs Dev Review

comment:10 Changed 9 years ago by Frank Dowsett <wixardy@…>

Resolution: fixed
Status: newclosed

(In e6ac16b25ae3) Use a short date in the about box. Fixes #13541

comment:11 Changed 9 years ago by Frank

Milestone: Adium bugsAdium 1.4.1
Patch Status: Needs Dev ReviewRejected

I found out, in looking at your patch, that we offer the short date already.

Note: See TracTickets for help on using tickets.